Merge pull request #7114 from pmattmann/feature/perf-content-nodes

Performance: /api/content_node/checklist_nodes

Author: pmattmann

api/migrations/schema/Version20250324224924.php

@@ -0,0 +1,27 @@
+<?php
+
+declare(strict_types=1);
+
+namespace DoctrineMigrations;
+
+use Doctrine\DBAL\Schema\Schema;
+use Doctrine\Migrations\AbstractMigration;
+
+/**
+ * Auto-generated Migration: Please modify to your needs!
+ */
+final class Version20250324224924 extends AbstractMigration {
+    public function getDescription(): string {
+        return 'ContentNode.RootId not nullable';
+    }
+
+    public function up(Schema $schema): void {
+        // this up() migration is auto-generated, please modify it to your needs
+        $this->addSql('ALTER TABLE content_node ALTER rootId SET NOT NULL');
+    }
+
+    public function down(Schema $schema): void {
+        // this down() migration is auto-generated, please modify it to your needs
+        $this->addSql('ALTER TABLE content_node ALTER rootid DROP NOT NULL');
+    }
+}

api/src/Entity/ContentNode.php

@@ -62,7 +62,7 @@ abstract class ContentNode extends BaseEntity implements BelongsToContentNodeTre
     #[Gedmo\SortableGroup] // this is needed to avoid that all root nodes are in the same sort group (parent:null, slot: '')
     #[Groups(['read'])]
     #[ORM\ManyToOne(targetEntity: ColumnLayout::class, inversedBy: 'rootDescendants')]
-    #[ORM\JoinColumn(nullable: true, onDelete: 'CASCADE')] // TODO make not null in the DB using a migration, and get fixtures to run
+    #[ORM\JoinColumn(nullable: false, onDelete: 'CASCADE')]
     public ?ColumnLayout $root = null;
 
     /**
@@ -186,6 +186,11 @@ public function getParent(): ?HasParentInterface {
         return $this->parent;
     }
 
+    public function setParent(?ContentNode $parent) {
+        $this->parent = $parent;
+        $this->root ??= $parent?->root;
+    }
+
     /**
      * Holds the actual data of the content node.
      */

api/tests/Api/ContentNodes/RootColumnLayout/CreateRootColumnLayoutTest.php

@@ -35,7 +35,7 @@ public function testCreateColumnLayoutValidatesMissingParent() {
         $this->assertJsonContains([
             'violations' => [
                 [
-                    'propertyPath' => 'parent',
+                    'propertyPath' => 'root',
                     'message' => 'This value should not be null.',
                 ],
             ],