Drop down item of resource scope filters of the history page no longer updated after...

[wahlbrink]

Version

7.2

Operating System

Windows

Eclipse version

2025-03

Bug description

The drop down item of the resource scope filters (in Repositoy, in Project, ...) of the Git history page is no longer updated after switching to another non-Git history page (and back).

Actual behavior

The icon and tooltip of the toolbar item is no longer updated/correct.

Expected behavior

The icon and tooltip of the toolbar item should always be up-to-date.

Relevant log output

Other information

No response

[wahlbrink]

The problem is that the lifecycle of a history toolbar is different from the lifecycle of the history page. The toolbar (action bar) is disposed when switching to another history page, but not the history page.

This is not taken into account in the Git history page / the FilterAction. If the toolbar is disposed, currently GitHistoryPageActions$FilterAction.dispose() is called and removes the required listeners, but the FilterAction is reused for the next toolbar.

GitHistoryPage$GitHistoryPageActions$ShowFilterAction(EventManager).removeListenerObject(Object) line: 121
GitHistoryPage$GitHistoryPageActions$ShowFilterAction(AbstractAction).removePropertyChangeListener(IPropertyChangeListener) line: 83
GitHistoryPage$GitHistoryPageActions$FilterAction.dispose() line: 397
ActionContributionItem.handleWidgetDispose(Event) line: 476
ActionContributionItem.lambda$5(Event) line: 449
Lambda.handleEvent(Event) line: not available
EventTable.sendEvent(Event) line: 91
Display.sendEvent(EventTable, Event) line: 4321
ToolItem(Widget).sendEvent(Event) line: 1208
ToolItem(Widget).sendEvent(int, Event, boolean) line: 1232
ToolItem(Widget).sendEvent(int) line: 1213
ToolItem(Widget).release(boolean) line: 890
ToolItem(Widget).dispose() line: 479
ToolBarManager.update(boolean) line: 324
ActionBars.updateActionBars() line: 68
GenericHistoryView(PageBookView).showPageRec(PageBookView$PageRec) line: 929
GenericHistoryView.showPageRec(PageBookView$PageRec) line: 576
GenericHistoryView(PageBookView).partActivated(IWorkbenchPart) line: 698
GenericHistoryView.showHistoryPageFor(Object, boolean, boolean, IHistoryPageSource) line: 625
GenericHistoryView.showLastSelectedElement() line: 564
GenericHistoryView$1.selectionChanged(IWorkbenchPart, ISelection) line: 406
SelectionService.notifyListeners(IWorkbenchPart, ISelection, ListenerList) line: 266

[wahlbrink]

Fix: https://eclipse.gerrithub.io/c/eclipse-egit/egit/+/1211343