From b722c8071718bcc84be808aae36aa6200b2b73de Mon Sep 17 00:00:00 2001 From: "Roger A. Light" Date: Sun, 3 May 2026 01:20:41 +0100 Subject: [PATCH 1/3] Windows: Use ninja for build --- .github/workflows/windows.yml | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/.github/workflows/windows.yml b/.github/workflows/windows.yml index 969f71e323..cba4b36f0b 100644 --- a/.github/workflows/windows.yml +++ b/.github/workflows/windows.yml @@ -54,12 +54,17 @@ jobs: triplet: ${{ matrix.triplet }} token: ${{ github.token }} + - name: Set up VS + uses: ilammy/msvc-dev-cmd@v1 + with: + arch: ${{ matrix.arch }} + - name: Configure CMake run: | cmake ` + -G Ninja ` -B ${{github.workspace}}/${{ matrix.buildloc }} ` -DCMAKE_BUILD_TYPE=${{env.BUILD_TYPE}} ` - -DCMAKE_GENERATOR_PLATFORM=${{ matrix.platform }} ` -DCMAKE_TOOLCHAIN_FILE=${{ github.workspace }}/vcpkg/scripts/buildsystems/vcpkg.cmake ` -DHTTP_API_DIR="C:\\${{ matrix.programfiles }}\\Mosquitto\\dashboard" ` -DVCPKG_MANIFEST_MODE=ON ` From 14bd2b5caac97b30294494b19d6f5eedc129e26c Mon Sep 17 00:00:00 2001 From: "Roger A. Light" Date: Sun, 3 May 2026 11:24:07 +0100 Subject: [PATCH 2/3] test --- .github/workflows/windows.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/windows.yml b/.github/workflows/windows.yml index cba4b36f0b..867016975f 100644 --- a/.github/workflows/windows.yml +++ b/.github/workflows/windows.yml @@ -85,6 +85,7 @@ jobs: - name: Installer uses: joncloud/makensis-action@v5.0 with: + arguments: "/V4" script-file: ${{github.workspace}}/installer/${{ matrix.nsis }} - name: Upload installer to artifacts From 0e6c925cf4726ac9ae98414114109a487bb4c2c7 Mon Sep 17 00:00:00 2001 From: "Roger A. Light" Date: Sun, 3 May 2026 22:46:00 +0100 Subject: [PATCH 3/3] installer --- installer/mosquitto.nsi | 6 +++--- installer/mosquitto64.nsi | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/installer/mosquitto.nsi b/installer/mosquitto.nsi index 653a0d9e70..d08807af9b 100644 --- a/installer/mosquitto.nsi +++ b/installer/mosquitto.nsi @@ -184,9 +184,9 @@ SectionEnd Section "Visual Studio Runtime" SetOutPath "$INSTDIR" - File "VC_redist.x86.exe" - ExecWait '"$INSTDIR\VC_redist.x86.exe" /quiet /norestart' - Delete "$INSTDIR\VC_redist.x86.exe" + File "vc_redist.x86.exe" + ExecWait '"$INSTDIR\vc_redist.x86.exe" /quiet /norestart' + Delete "$INSTDIR\vc_redist.x86.exe" SectionEnd Section "Service" SecService diff --git a/installer/mosquitto64.nsi b/installer/mosquitto64.nsi index caee3fddf7..853128285c 100644 --- a/installer/mosquitto64.nsi +++ b/installer/mosquitto64.nsi @@ -185,9 +185,9 @@ SectionEnd Section "Visual Studio Runtime" SetOutPath "$INSTDIR" - File "VC_redist.x64.exe" - ExecWait '"$INSTDIR\VC_redist.x64.exe" /quiet /norestart' - Delete "$INSTDIR\VC_redist.x64.exe" + File "vc_redist.x64.exe" + ExecWait '"$INSTDIR\vc_redist.x64.exe" /quiet /norestart' + Delete "$INSTDIR\vc_redist.x64.exe" SectionEnd Section "Service" SecService