Fix setTextContainingScript Test #1466

amartya4256 · amartya4256 · commit 3dbeab4fa8c2 · 2025-05-21T17:24:25.000+02:00
This commit fixes the test org.eclipse.swt.tests.junit.Test_org_eclipse_swt_browser_Browser.test_setTextContainingScript_applicationLayerProgressListenerMustSeeUpToDateDom() as Edge seems to misbehave sporadically when an invalid script source is added using Edge:setText. Hence, with this commit we replace the script tag with a valid statement in the test and enable it. Contributes to #1466
diff --git a/tests/org.eclipse.swt.tests/JUnit Tests/org/eclipse/swt/tests/junit/Test_org_eclipse_swt_browser_Browser.java b/tests/org.eclipse.swt.tests/JUnit Tests/org/eclipse/swt/tests/junit/Test_org_eclipse_swt_browser_Browser.java
@@ -1141,7 +1141,6 @@ public void test_setText() {
  */
 @Test
 public void test_setTextContainingScript_applicationLayerProgressListenerMustSeeUpToDateDom() {
-	assumeFalse("Toggling on Edge since I20250216-1800, see https://github.com/eclipse-platform/eclipse.platform.swt/issues/1843", isEdge);
 	AtomicBoolean completed = new AtomicBoolean();
 	browser.addProgressListener(ProgressListener.completedAdapter(event -> {
 		String script = """
@@ -1162,7 +1161,7 @@ public void test_setTextContainingScript_applicationLayerProgressListenerMustSee
 	browser.setText("""
 			<html>
 				<head>
-					<script src=\"file:///does/not/really/needs/to/exist.js\"></script>
+					<script>console.log("test");</script>
 				</head>
 				<body>
 					<h1>Hello, World!</h1>
