Skip to content

Commit 51b87c9

Browse files
committed
Revert "Preserved width/height on scaleUp/Down a Rectangle"
The change introduced a regression with borders in CTabFolder at different scale values, so this reverts to the state before. This reverts commit d4caabf.
1 parent 58c5cb9 commit 51b87c9

File tree

2 files changed

+2
-23
lines changed
  • bundles/org.eclipse.swt/Eclipse SWT/common/org/eclipse/swt/internal
  • tests/org.eclipse.swt.tests/JUnit Tests/org/eclipse/swt/tests/junit

2 files changed

+2
-23
lines changed

bundles/org.eclipse.swt/Eclipse SWT/common/org/eclipse/swt/internal/DPIUtil.java

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -257,17 +257,6 @@ public static Rectangle scaleDown(Rectangle rect, int zoom) {
257257
scaledRect.y = scaledTopLeft.y;
258258
scaledRect.width = scaledBottomRight.x - scaledTopLeft.x;
259259
scaledRect.height = scaledBottomRight.y - scaledTopLeft.y;
260-
261-
int scaledDownWidth = DPIUtil.scaleDown(rect.width, zoom);
262-
int scaledDownHeight = DPIUtil.scaleDown(rect.height, zoom);
263-
264-
// It must be ensured, that a scaled down width or height
265-
// based on Rectangle x or y is not bigger than directly
266-
// scaling down the width or height. Therefore the min
267-
// value is used
268-
scaledRect.width = Math.min(scaledRect.width, scaledDownWidth);
269-
scaledRect.height = Math.min(scaledRect.height, scaledDownHeight);
270-
271260
return scaledRect;
272261
}
273262
/**
@@ -476,16 +465,6 @@ public static Rectangle scaleUp(Rectangle rect, int zoom) {
476465
scaledRect.y = scaledTopLeft.y;
477466
scaledRect.width = scaledBottomRight.x - scaledTopLeft.x;
478467
scaledRect.height = scaledBottomRight.y - scaledTopLeft.y;
479-
480-
int scaledUpWidth = DPIUtil.scaleUp(rect.width, zoom);
481-
int scaledUpHeight = DPIUtil.scaleUp(rect.height, zoom);
482-
483-
// It must be ensured, that a scaled up width or height
484-
// based on Rectangle x or y is not smaller that directly
485-
// scaling up the width or height. Therefore the max
486-
// value is used
487-
scaledRect.width = Math.max(scaledRect.width, scaledUpWidth);
488-
scaledRect.height = Math.max(scaledRect.height, scaledUpHeight);
489468
return scaledRect;
490469
}
491470

tests/org.eclipse.swt.tests/JUnit Tests/org/eclipse/swt/tests/junit/DPIUtilTests.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@ public void scaleDownPoint() {
160160
@Test
161161
public void scaleDownRectangle() {
162162
Rectangle valueAt200 = new Rectangle(100, 150, 10, 14);
163-
Rectangle valueAt150 = new Rectangle(75, 113, 7, 11);
163+
Rectangle valueAt150 = new Rectangle(75, 113, 7, 10);
164164
Rectangle valueAt100 = new Rectangle(50, 75, 5, 7);
165165

166166
Rectangle scaledValue = DPIUtil.autoScaleDown(valueAt200);
@@ -295,7 +295,7 @@ public void scaleUpPoint() {
295295
@Test
296296
public void scaleUpRectangle() {
297297
Rectangle valueAt200 = new Rectangle(100, 150, 10, 14);
298-
Rectangle valueAt150 = new Rectangle(75, 113, 8, 11);
298+
Rectangle valueAt150 = new Rectangle(75, 113, 8, 10);
299299
Rectangle valueAt100 = new Rectangle(50, 75, 5, 7);
300300

301301
Rectangle scaledValue = DPIUtil.autoScaleUp(valueAt100);

0 commit comments

Comments
 (0)