Links in empty Package Explorer are cut off

[iloveeclipse]

I'm using Windows 11 with 125% monitor scaling.
It looks like one of the recent changes broke the dimensions calculation for Link elements, because they are cut off now:

Switching "Monitor specific UI scaling" off fixes the problem:

Note: I have a notebook with a single built-in monitor and no other monitors connected to it.

[iloveeclipse]

@HeikoKlare : eclipse-platform/eclipse.platform.ui#2868 is the trigger for the preference being enabled now, but I guess the real bug in in SWT.

[fedejeanne]

cc @akoch-yatta

[fedejeanne]

My initial analysis revealed that the issue is in the GridLayout class, which sometimes passes the wrong childHeight to setBounds(...) here:

eclipse.platform.swt/bundles/org.eclipse.swt/Eclipse SWT/common/org/eclipse/swt/layout/GridLayout.java

Line 697 in 0fe4a76

child.setBounds (childX, childY, childWidth, childHeight);

I noticed that this only happens with certain widths and when changing to monitors with zoom != 100. Decreasing the width of the panel forces a recalculation and it fixes the issue. Increasing the width again reproduces the issue.

I'm going to look at it more in detail later this week and try to propose a fix. If anyone has an idea, it's appreciated.

[fedejeanne]

Caused by #1769 (@akoch-yatta)