Skip to content

Links in empty Package Explorer are cut off #2003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iloveeclipse opened this issue Apr 6, 2025 · 7 comments · Fixed by #2047
Open

Links in empty Package Explorer are cut off #2003

iloveeclipse opened this issue Apr 6, 2025 · 7 comments · Fixed by #2047
Assignees
Labels
bug Something isn't working regression Something that used to work Windows Happens on Windows OS

Comments

@iloveeclipse
Copy link
Member

iloveeclipse commented Apr 6, 2025

I'm using Windows 11 with 125% monitor scaling.
It looks like one of the recent changes broke the dimensions calculation for Link elements, because they are cut off now:

Image

Switching "Monitor specific UI scaling" off fixes the problem:

Image

Note: I have a notebook with a single built-in monitor and no other monitors connected to it.

@iloveeclipse iloveeclipse added bug Something isn't working regression Something that used to work labels Apr 6, 2025
@iloveeclipse
Copy link
Member Author

@HeikoKlare : eclipse-platform/eclipse.platform.ui#2868 is the trigger for the preference being enabled now, but I guess the real bug in in SWT.

@fedejeanne
Copy link
Contributor

cc @akoch-yatta

@fedejeanne fedejeanne transferred this issue from eclipse-platform/eclipse.platform.ui Apr 7, 2025
@fedejeanne
Copy link
Contributor

fedejeanne commented Apr 7, 2025

My initial analysis revealed that the issue is in the GridLayout class, which sometimes passes the wrong childHeight to setBounds(...) here:

child.setBounds (childX, childY, childWidth, childHeight);

I noticed that this only happens with certain widths and when changing to monitors with zoom != 100. Decreasing the width of the panel forces a recalculation and it fixes the issue. Increasing the width again reproduces the issue.

I'm going to look at it more in detail later this week and try to propose a fix. If anyone has an idea, it's appreciated.

@fedejeanne
Copy link
Contributor

fedejeanne commented Apr 8, 2025

Caused by #1769 (@akoch-yatta)

akoch-yatta added a commit to vi-eclipse/eclipse.platform.swt that referenced this issue Apr 22, 2025
This commit extends the logic when a Rectangle is scaled up/down from points
to pixels regarding width and height.

Fixes eclipse-platform#2003
akoch-yatta added a commit to vi-eclipse/eclipse.platform.swt that referenced this issue Apr 22, 2025
This commit extends the logic when a Rectangle is scaled up/down from points
to pixels regarding width and height.

Fixes eclipse-platform#2003
HeikoKlare pushed a commit to vi-eclipse/eclipse.platform.swt that referenced this issue Apr 23, 2025
This commit extends the logic when a Rectangle is scaled up/down from points
to pixels regarding width and height.

Fixes eclipse-platform#2003
HeikoKlare pushed a commit to vi-eclipse/eclipse.platform.swt that referenced this issue Apr 23, 2025
This commit extends the logic when a Rectangle is scaled up/down from points
to pixels regarding width and height.

Fixes eclipse-platform#2003
HeikoKlare pushed a commit that referenced this issue Apr 23, 2025
This commit extends the logic when a Rectangle is scaled up/down from points
to pixels regarding width and height.

Fixes #2003
@HeikoKlare
Copy link
Contributor

Reopening as the solution attempt introduced a regression and had to be reverted: #2095

We will propose an updated fix soon.

@HeikoKlare HeikoKlare reopened this May 5, 2025
akoch-yatta added a commit to vi-eclipse/eclipse.platform.ui that referenced this issue May 13, 2025
This commit adjusts the grid layout in EmptyWorkspaceHelper to address
an issue in Windows with monitor specific scaling active. This commit
will not fully solve the issue, but significantly lower the scenarios
when it is triggered.

Contributes to eclipse-platform/eclipse.platform.swt#2003
HeikoKlare pushed a commit to eclipse-platform/eclipse.platform.ui that referenced this issue May 13, 2025
This commit adjusts the grid layout in EmptyWorkspaceHelper to address
an issue in Windows with monitor specific scaling active. This commit
will not fully solve the issue, but significantly lower the scenarios
when it is triggered.

Contributes to eclipse-platform/eclipse.platform.swt#2003
@deepika-u
Copy link
Contributor

Hi, I still see this issue on latest build Eclipse SDK Version: 2025-06 (4.36), Build id: I20250519-1800, OS: Windows 11, v.10.0, x86_64 / win32, Java vendor: Oracle Corporation, Java runtime version: 24+36-3646, Java version: 24

I am on default scaling provided by windows 11(125% recommended) on my laptop.

Image

@HeikoKlare
Copy link
Contributor

I can confirm that this also happens for me in the Git repositories view with the same configuration:
Image

It does not occur for the package explorer though.

akoch-yatta added a commit to akoch-yatta/egit that referenced this issue May 20, 2025
This commit adjusts the grid layout in RepositoriesView when no
repositories are added yet to address an issue in Windows with monitor
specific scaling active.

Contributes to eclipse-platform/eclipse.platform.swt#2003
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working regression Something that used to work Windows Happens on Windows OS
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants