Skip to content

Commit 087912d

Browse files
committed
This PR removes the only remaining WS_CARBON check from the codebase.
The Carbon backend is no longer used or supported in SWT, as all modern macOS environments use the Cocoa backend (WS_COCOA). This check is now obsolete and can be removed.
1 parent a4840da commit 087912d

File tree

2 files changed

+2
-8
lines changed

2 files changed

+2
-8
lines changed

bundles/org.eclipse.jface/src/org/eclipse/jface/util/Util.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -560,7 +560,7 @@ public static boolean isWindows() {
560560
*/
561561
public static boolean isMac() {
562562
final String ws = SWT.getPlatform();
563-
return WS_CARBON.equals(ws) || WS_COCOA.equals(ws);
563+
return WS_COCOA.equals(ws);
564564
}
565565

566566
/**

bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/keys/BindingPersistence.java

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -519,7 +519,7 @@ private static final void readBindingsFromPreferences(final IMemento preferences
519519
* @param commandService The command service for the workbench; must
520520
* not be <code>null</code>.
521521
*/
522-
@SuppressWarnings("removal")
522+
// @SuppressWarnings("removal")
523523
private static final void readBindingsFromRegistry(final IConfigurationElement[] configurationElements,
524524
final int configurationElementCount, final BindingManager bindingManager,
525525
final CommandManager commandService) {
@@ -608,12 +608,6 @@ private static final void readBindingsFromRegistry(final IConfigurationElement[]
608608

609609
if (Util.WS_COCOA.equals(platform)) {
610610
cocoaTempList.add(binding);
611-
} else if (Util.WS_CARBON.equals(platform)) {
612-
bindings.add(binding);
613-
// temp work around ... simply honour the carbon
614-
// bindings for cocoa.
615-
cocoaTempList.add(new KeyBinding(keySequence, parameterizedCommand, schemeId, contextId, locale,
616-
Util.WS_COCOA, null, Binding.SYSTEM));
617611
} else {
618612
bindings.add(binding);
619613
}

0 commit comments

Comments
 (0)