You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Lets assume that the used commandId is a platform id (for example: org.eclipse.ui.edit.rename)
This commandId has been added to a context menu via this location URI: popup:#TextEditorContext:
The displayed key binding in the context menu does not reflect the correct key binding (see this lsp4e issue #1259), because the contextId is not considered when the MenuItem gets updated here .
If there are more than one binding for a ParameterizedCommand, the first one gets selected after they have been sorted here.
As "F2" is shorter than "M2+M3+R", "F2" is sorted before "M2+M3+R" and gets displayed in the menu entry. This behavior leads to confused users as they expect another key binding in their editor.
Community
I understand reporting an issue to this OSS project does not mandate anyone to fix it. Other contributors may consider the issue, or not, at their own convenience. The most efficient way to get it fixed is that I fix it myself and contribute it back as a good quality patch to the project.
The text was updated successfully, but these errors were encountered:
I would like to. I just look for a way to determine the context id when the MenuItem gets updated. It looks to me that the org.eclipse.e4.ui.bindings.internal.BindingTableManager holds no (direct) information about the context.
ghentschke
added a commit
to ghentschke/eclipse.platform.text-fork
that referenced
this issue
May 11, 2025
Consider the Binding context when there is more than one Binding
for a ParametrizedCommand. The deeper/specialized context will be
preferred.
fixeseclipse-platform#2968
The
org.eclipse.ui.bindings
extension point allows to define a key sequence for a given commandId in a schemeId:Lets assume that the used commandId is a platform id (for example:
org.eclipse.ui.edit.rename
)This commandId has been added to a context menu via this location URI: popup:#TextEditorContext:
The displayed key binding in the context menu does not reflect the correct key binding (see this lsp4e issue #1259), because the contextId is not considered when the
MenuItem
gets updated here .If there are more than one binding for a
ParameterizedCommand
, the first one gets selected after they have been sorted here.As "F2" is shorter than "M2+M3+R", "F2" is sorted before "M2+M3+R" and gets displayed in the menu entry. This behavior leads to confused users as they expect another key binding in their editor.
Community
The text was updated successfully, but these errors were encountered: