QuickAccessEntry paint problems

[merks]

I've been seeing this the last days and just now testing M3. I finally realized it happens when I type in the quick access control while trying to show the error log view:

java.lang.IllegalArgumentException: Argument not valid
	at org.eclipse.swt.SWT.error(SWT.java:4926)
	at org.eclipse.swt.SWT.error(SWT.java:4860)
	at org.eclipse.swt.SWT.error(SWT.java:4831)
	at org.eclipse.swt.graphics.GC.drawImage(GC.java:1044)
	at org.eclipse.swt.graphics.GC.drawImage(GC.java:994)
	at org.eclipse.ui.internal.quickaccess.QuickAccessEntry.paint(QuickAccessEntry.java:238)
	at org.eclipse.ui.internal.quickaccess.QuickAccessContents.lambda$11(QuickAccessContents.java:853)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:91)
	at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4338)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1214)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1238)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1223)
	at org.eclipse.swt.widgets.Table.sendPaintItemEvent(Table.java:3934)
	at org.eclipse.swt.widgets.Table.CDDS_SUBITEMPOSTPAINT(Table.java:951)
	at org.eclipse.swt.widgets.Table.wmNotifyChild(Table.java:6728)
	at org.eclipse.swt.widgets.Control.wmNotify(Control.java:5859)
	at org.eclipse.swt.widgets.Composite.wmNotify(Composite.java:1981)
	at org.eclipse.swt.widgets.Control.WM_NOTIFY(Control.java:5426)
	at org.eclipse.swt.widgets.Control.windowProc(Control.java:4835)
	at org.eclipse.swt.widgets.Display.windowProc(Display.java:5106)
	at org.eclipse.swt.internal.win32.OS.CallWindowProc(Native Method)
	at org.eclipse.swt.widgets.Table.callWindowProc(Table.java:585)
	at org.eclipse.swt.widgets.Table.callWindowProc(Table.java:451)
	at org.eclipse.swt.widgets.Control.windowProc(Control.java:4881)
	at org.eclipse.swt.widgets.Table.windowProc(Table.java:5812)
	at org.eclipse.swt.widgets.Display.windowProc(Display.java:5106)
	at org.eclipse.swt.internal.win32.OS.DispatchMessage(Native Method)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3722)
	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$5.run(PartRenderingEngine.java:1151)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:339)
	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1042)
	at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:153)
	at org.eclipse.ui.internal.Workbench.lambda$3(Workbench.java:678)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:339)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:583)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:173)
	at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:185)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:219)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:149)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:115)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:467)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:298)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:627)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:575)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1431)

[merks]

I couldn't reproduce it in a debug launch... If no one has an idea, I could try to remote debug it...

[merks]

I don't know if these details help:

It just seems to me something is wrong in the logic here because none of the inputs look wrong...

[HeikoKlare]

If it was not present in M2, it might be related to this change: eclipse-platform/eclipse.platform.swt#2138
I will try to have a look. fyi @akoch-yatta

[HeikoKlare]

This seems to be caused by:

eclipse.platform.ui/bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/dialogs/OpenResourceQuickAccessComputer.java

Line 110 in 84a3413

return ImageDescriptor.createFromImageDataProvider(zoom -> fLabelProvider.getImage(fFile).getImageData());

It creates the same image data with the same sizes for every zoom, obviously breaking some assumption in Image that bounds can be scaled from some image data to calculate the bounds for other zooms.

[HeikoKlare]

Obivously we need to fix OpenResourceQuickAccessComputer to pass through the zoom. That's easy to do. I I just wonder if there is some wrong assumption in the GC code here that might also break for other images. I will have a further look.