ThreadX modules and SMP

[yf13]

@billamiework and @goldscott, can you teach if ThreadX modules support SMP or not?

On one side, we have ports_module/cortex_a35_smp, so modules should support SMP already.

On the other side, I got following error when building modules with my RiscV SMP port:

[243/342] Building C object CMakeFiles...txm_module_manager_thread_create.c.obj
...
txm_module_manager_thread_create.c:671:30: warning: assignment to 'TX_THREAD *' {aka 'struct TX_THREAD_STRUCT *'} from incompatible pointer type 'TX_THREAD **' {aka 'struct TX_THREAD_STRUCT **'} [-Wincompatible-pointer-types]
  671 |             saved_thread_ptr =  _tx_thread_execute_ptr;

[fdesbiens]

Thank you for reaching out @yf13. I will discuss this with the team.

[billlamiework]

Hi @yf13,

It looks like you are correct - I see the ports_module/cortex_a35_smp folder and the contents do appear to support SMP mode. Don't forget that you should also make sure you are using the threadx/common_smp generic source code (non Module source). For example, there are macros that convert _tx_thread_execute_ptr into an array (indexed by core) for SMP use. Hopefully, that will helps!

[fdesbiens]

@yf13 Do you still need assistance? Otherwise, I will close this issue.

[yf13]

@billlamiework and @fdesbiens, thanks for the information.
Acutally I am still having puzzles. The txm_module_manager_thread_create.c belongs to common_modules/module_manager. Thus it doesn't support SMP.

If we are not missing a common_modules_smp/ folder, then the current version of common_modules/ should be upgraded to support SMP?

[billlamiework]

Hi @yf13,
Have you actually tried to build an SMP version or is it just concerning that there isn't a common_modules_smp folder? I ask because there are macro redefines for SMP that convert ThreadX from single core to SMP.

[yf13]

@have you actually tried to build an SMP version

Yes I did and got build error as shown in issue description.

[billlamiework]

Hi @yf13,
I see the build error now at the beginning of the thread, and it does appear something is missing with SMP and module support. If you want to discuss some options for recreating this support, please feel free to reach out to me via email: blamie@px5rtos.com

[fdesbiens]

Closing this issue due to inactivity. Feel free to reopen or create a new one as needed.