-
Notifications
You must be signed in to change notification settings - Fork 828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comment on posix condition variable implementation looks bogus #419
Comments
Thanks for raising this issue, @wucke13. Looking at the code, I think the comment should read:
What do you think? |
The comment can be refined as following: --- a/utility/rtos_compatibility_layers/posix/px_cond_signal.c
+++ b/utility/rtos_compatibility_layers/posix/px_cond_signal.c
@@ -89,7 +89,7 @@ TX_SEMAPHORE *semaphore_ptr;
UINT status;
/* Get the condition variable's internal semaphore. */
- /* Simply convert the COndition variable control block into a semaphore a cast */
+ /* Simply convert the condition variable control block into a semaphore using casting */
semaphore_ptr = (&( cond->cond_semaphore ));
if ( semaphore_ptr->tx_semaphore_suspended_count)
{ |
Seems sensible to me! |
@wucke13 Just to confirm I will make the change. I will take care of this next week, as I am on a trip right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
threadx/utility/rtos_compatibility_layers/posix/px_cond_signal.c
Line 92 in 485a02f
The text was updated successfully, but these errors were encountered: