Skip to content

get rid of internal_config feature #1655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
milyin opened this issue Dec 10, 2024 · 1 comment · May be fixed by #1939
Open

get rid of internal_config feature #1655

milyin opened this issue Dec 10, 2024 · 1 comment · May be fixed by #1939
Assignees
Labels
release Part of the next release

Comments

@milyin
Copy link
Contributor

milyin commented Dec 10, 2024

Describe the release item

The feature internal_config can be removed, it's functionality can be put under internal feature.

Though to achieve this goal one of these things should be done:

  • either the internal should not suppose unstable. E.g. test for liveliness which actively uses this write access to config should use internal feature, but not unstable. This is nesessary for run tests in stable mode #1654
  • or the tests should not use this direct access to config, using set methods instead
@wyfo
Copy link
Contributor

wyfo commented May 12, 2025

Why not exposing the config if either internal or unstable feature is used? Replacing #[cfg(feature = "internal_config")] with #[cfg(any(feature = "internal", feature = "unstable"))].

@wyfo wyfo linked a pull request May 12, 2025 that will close this issue
@wyfo wyfo self-assigned this May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Part of the next release
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

2 participants