Skip to content

Add docstrings to facilitate newcomers getting started #478

@MatKbauer

Description

@MatKbauer

What maintenance does this project need?

Some classes and functions are hard to understand for newcomers due to sparse documentation and missing docstrings, in particular. Improvements can be made to the following classes.

model.py: The predict function of the Model class could be confusing, as it rather decodes from latent to physical space (thanks to @kctezcan for explaining) instead of generating a prediction. On the other hand, the decoder fills gaps, which are predictions then. Any thoughts on how to make this more approachable appreciated. A corresponding docstring should resolve this unclarity or predict can be renamed in decode.

engines.py: Write docstrings to describe more exhaustively what each engine is doing. I.e., what's the difference between local and global assimilation engine?

attention.py: Add docstrings and describe the purpose of the different attention heads (local, varlen, flexed, slicedq)

Organisation

ECMWF

Metadata

Metadata

Assignees

No one assigned

    Labels

    documentationImprovements or additions to documentationmodelRelated to model training or definition (not generic infra)qualityImproves code quality

    Type

    Projects

    Status

    No status

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions