-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: Recompute cumulated fields when combining datasets with different frequency #222
Comments
Hello @mpvginde did you get an answer to your questions ? I am very interested by the topic too, and I am willing to contribute to a PR if you want to start one (maybe with the help of Baudouin). If the cumulation information is anywhere (layman here), it should be in the datasets metadata ? Probably we might want this information to lie in the .zarr anyway, so that we can get it to work on the use-case you describe (merging datasets with different frequencies, when already having them as .zarr's). This might be starting point to either check if cumulation params are in the .zarr, or build a small filter (anemoi-transforms ?) to set them in the recipe. I'd like to give this a try on local datasets of mine. Then for the recomputation, do you already have an entrypoint ? I guess concat.py would do the job, if we can add kwargs to recompute some fields (and then provide the cumulation routines under compute). |
Hi @flyIchtus,
The class that sums the consecutive dates should inherit from
As inputs it would need I probably will start working on it end of march, but you can go ahead if you want ofcourse. |
Great Michiel I think this is a good starting point.
So I guess this is part of what we want. |
If I understand correctly, the current behavior when combining e.g. a dataset with 6h and 3h temporal frequency is that all the fields at the intersecting dates (i.e. every 6h) are kept without any additional computations.
This means that the adjusted 3h-freq dataset know has a new 6h-frequency, but e.g. the
tp
field still represents 3h-accumulation.It would be useful introduce a feature that allows for the automatic recalculation of the cumulated fields, so that the adjusted datasets represent the same accumulations.
I'm willing to give it a try, but I was wondering what information is present about the fields in the dataset.
Does the dataset know which fields are accumulated and is there information about the accumulation period in the dataset?
BR,
Michiel
The text was updated successfully, but these errors were encountered: