Attempt to fix VirtualCall static analyzer warnings

Author: wdeconinck

pluto/src/pluto/memory_resource/MemoryPoolResource.cc

@@ -337,7 +337,7 @@ std::size_t MemoryPoolResource::capacity() const {
     return _capacity;
 }
 
-void MemoryPoolResource::release() {
+void MemoryPoolResource::do_release() {
     std::lock_guard lock(mtx_);
 #if PLUTO_DEBUGGING
     for (std::size_t i = 0; i < pool_block_sizes_.size(); ++i) {
@@ -357,5 +357,9 @@ void MemoryPoolResource::release() {
     pools_.clear();
 }
 
+void MemoryPoolResource::release() {
+  do_release();
+}
+
 
 }  // namespace pluto

pluto/src/pluto/memory_resource/MemoryPoolResource.h

@@ -39,7 +39,7 @@ class MemoryPoolResource : public memory_pool_resource {
         memory_tracker_ = memory_tracker;
     }
 
-    virtual ~MemoryPoolResource() { release(); }
+    virtual ~MemoryPoolResource() { do_release(); }
 
     void release() override;
 
@@ -61,6 +61,7 @@ class MemoryPoolResource : public memory_pool_resource {
     void* do_allocate_async(std::size_t bytes, std::size_t alignment, stream_view) override;
     void do_deallocate_async(void* ptr, std::size_t bytes, std::size_t alignment, stream_view) override;
     bool do_is_equal(const memory_resource& other) const noexcept override;
+    void do_release();
     friend void callback_deallocate_async(void* stream);
 
     // A suitable pool or upstream resource to allocate given bytes

src/atlas/array/native/NativeDataStore.h

@@ -96,7 +96,7 @@ static pluto::memory_resource* device_resource(bool shared) {
 
 
 template <typename Value>
-class DataStore : public ArrayDataStore {
+class DataStore final : public ArrayDataStore {
 public:
     DataStore(size_t size): size_(size),
         is_shared_data_{test_device_is_shared()},
@@ -285,7 +285,7 @@ class DataStore : public ArrayDataStore {
 //------------------------------------------------------------------------------
 
 template <typename Value>
-class WrappedDataStore : public ArrayDataStore {
+class WrappedDataStore final : public ArrayDataStore {
 public:
 
     void init_device() {

src/atlas/mesh/Connectivity.cc

@@ -453,7 +453,6 @@ MultiBlockConnectivityImpl::MultiBlockConnectivityImpl(eckit::Stream& s): Irregu
 //------------------------------------------------------------------------------------------------------
 
 MultiBlockConnectivityImpl::~MultiBlockConnectivityImpl() {
-    clear();
 }
 
 //------------------------------------------------------------------------------------------------------