PR comments

Author: danovaro

src/metkit/mars/StepRange.cc

@@ -101,8 +101,6 @@ void StepRange::print(std::ostream& s) const
         eckit::Time f{static_cast<long>(from_*3600.), true};
         eckit::Time t{static_cast<long>(to_*3600.), true};
 
-        TimeUnit unit = std::min(maxUnit(f), maxUnit(t));
-        // s << canonical(f, unit) << '-' << canonical(t, unit);
         s << canonical(f) << '-' << canonical(t);
     }
 }

tests/test_expand.cc

@@ -287,6 +287,7 @@ CASE( "test_metkit_expand_13_step" ) {
     step("0-6/to/18-24/by/6", "0-6/6-12/12-18/18-24");
     step("0-24/to/48-72/by/24", "0-24/24-48/48-72");
     step("0/to/24/by/3/0-6/to/18-24/by/6", "0/3/6/9/12/15/18/21/24/0-6/6-12/12-18/18-24");
+    step("0-24/to/24-48/by/90m", "0-24/1h30m-25h30m/3-27/4h30m-28h30m/6-30/7h30m-31h30m/9-33/10h30m-34h30m/12-36/13h30m-37h30m/15-39/16h30m-40h30m/18-42/19h30m-43h30m/21-45/22h30m-46h30m/24-48");
 }