forked from kubeflow/model-registry
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(inferenceservice): added integration tests to inferenceservice r…
…econcile function (kubeflow#574) * feat: added integration tests to inferenceservice reconcile func Signed-off-by: Alessio Pragliola <[email protected]> * chore(isvc): keep the crds folder and document Signed-off-by: Alessio Pragliola <[email protected]> --------- Signed-off-by: Alessio Pragliola <[email protected]>
- Loading branch information
1 parent
3285729
commit 257b85b
Showing
9 changed files
with
469 additions
and
18 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,6 +6,10 @@ GO ?= "$(shell which go)" | |
| BFF_PATH := $(PROJECT_PATH)/clients/ui/bff | ||
| UI_PATH := $(PROJECT_PATH)/clients/ui/frontend | ||
|
|
||
| # ENVTEST_K8S_VERSION refers to the version of kubebuilder assets to be downloaded by envtest binary. | ||
| ENVTEST_K8S_VERSION = 1.29 | ||
| ENVTEST ?= $(PROJECT_BIN)/setup-envtest | ||
|
|
||
| # add tools bin directory | ||
| PATH := $(PROJECT_BIN):$(PATH) | ||
|
|
||
|
|
@@ -133,6 +137,9 @@ bin/protoc-gen-go: | |
| bin/protoc-gen-go-grpc: | ||
| GOBIN=$(PROJECT_BIN) ${GO} install google.golang.org/grpc/cmd/[email protected] | ||
|
|
||
| bin/envtest: | ||
| GOBIN=$(PROJECT_BIN) ${GO} install sigs.k8s.io/controller-runtime/tools/[email protected] | ||
|
|
||
| GOLANGCI_LINT ?= ${PROJECT_BIN}/golangci-lint | ||
| bin/golangci-lint: | ||
| curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(PROJECT_BIN) v1.61.0 | ||
|
|
@@ -164,7 +171,7 @@ clean/deps: | |
| rm -Rf bin/* | ||
|
|
||
| .PHONY: deps | ||
| deps: bin/protoc bin/go-enum bin/protoc-gen-go bin/protoc-gen-go-grpc bin/golangci-lint bin/goverter bin/openapi-generator-cli | ||
| deps: bin/protoc bin/go-enum bin/protoc-gen-go bin/protoc-gen-go-grpc bin/golangci-lint bin/goverter bin/openapi-generator-cli bin/envtest | ||
|
|
||
| .PHONY: vendor | ||
| vendor: | ||
|
|
@@ -200,16 +207,16 @@ lint: | |
| ${GOLANGCI_LINT} run cmd/... internal/... ./pkg/... | ||
|
|
||
| .PHONY: test | ||
| test: gen | ||
| ${GO} test ./internal/... ./pkg/... | ||
| test: gen bin/envtest | ||
| KUBEBUILDER_ASSETS="$(shell $(ENVTEST) use $(ENVTEST_K8S_VERSION) -p path)" ${GO} test ./internal/... ./pkg/... | ||
|
|
||
| .PHONY: test-nocache | ||
| test-nocache: gen | ||
| ${GO} test ./internal/... ./pkg/... -count=1 | ||
| test-nocache: gen bin/envtest | ||
| KUBEBUILDER_ASSETS="$(shell $(ENVTEST) use $(ENVTEST_K8S_VERSION) -p path)" ${GO} test ./internal/... ./pkg/... -count=1 | ||
|
|
||
| .PHONY: test-cover | ||
| test-cover: gen | ||
| ${GO} test ./internal/... ./pkg/... -coverprofile=coverage.txt | ||
| test-cover: gen bin/envtest | ||
| KUBEBUILDER_ASSETS="$(shell $(ENVTEST) use $(ENVTEST_K8S_VERSION) -p path)" ${GO} test ./internal/... ./pkg/... -coverprofile=coverage.txt | ||
| ${GO} tool cover -html=coverage.txt -o coverage.html | ||
|
|
||
| .PHONY: run/proxy | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.