bad device value need detail and response error message

[sdvdxl]

🚀 Feature Request

Relevant Package [REQUIRED]

when device send bad value, we need know what happend.

Description [REQUIRED]

For example, if I define a property as temperature, the data type is float64, but the data sent is "a", then it should return this error through a topic, not just in the service log, and the log does not print the data of which device send the data.

Describe the solution you'd like

1. add a topic to response the error message
2. log detail, add device info

Describe alternatives you've considered

Have you considered any alternative solutions or workarounds?

[jiekechoo]

@sdvdxl Please provide your device profile and device configuration.

[cloudxxx8]

The log message can be improved from here

device-mqtt-go/internal/driver/incominglistener.go

Lines 92 to 96 in e552023

	commandValue, err := newResult(resource, asyncValue)
	if err != nil {
	driver.Logger.Errorf("[Incoming listener] Incoming data ignored: %v", err)
	return
	}

[lindseysimple]

Describe the solution you'd like

1. add a topic to response the error message
2. log detail, add device info

Hi @sdvdxl , based on the Device WG discussion on 16 Jan, 2024

1. For the 1st solution add a topic to response the error message you suggested, since this will be a new feature for EdgeX, we need a UCR for the community to review.

   If you think this feature would be helpful for you and across EdgeX, please go ahead and submit a UCR. Please note that UCR is a high level requirements documentation, and we don't need implementation details on it.

   • Here is the documentation on the process of UCR and ADR: https://docs.edgexfoundry.org/3.1/design/Process/.
   • Existing UCR examples: https://docs.edgexfoundry.org/3.1/design/TOC/#use-case-records-ucrs

   Another workaround for now is to use some external tools such as Logstash to centralize and monitor the service logs.

2. For the 2nd solution log detail, add device info, can you add some description on what's the other details you would like to be included in the log except for the device name, and it would be great if you have some bandwidth to work on this!

Thanks and please let me know if you have any further questions.

[sdvdxl]

For the 2nd solution log detail, add device info, can you add some description on what's the other details you would like to be included in the log except for the device name, and it would be great if you have some bandwidth to work on this!

maybe include device name, device profile?

[cloudxxx8]

Please feel free to opne a new PR to include them