Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring: Refresh testify's implementation of assert tests #13

Open
eduncan911 opened this issue Jun 23, 2016 · 0 comments
Open

Refactoring: Refresh testify's implementation of assert tests #13

eduncan911 opened this issue Jun 23, 2016 · 0 comments
Assignees

Comments

@eduncan911
Copy link
Owner

eduncan911 commented Jun 23, 2016

It's time to refresh the testify implementation of our assert package. I originally chose to embed it into the mspec package for several reasons:

  • To remove dependencies from the code.
  • The author said that testify wasn't stable yet and could change at that time.
  • I didn't want to increase complexity with package management, just to run tests.
  • Some assert tests could not be ported as-is.
  • Needed to override their error handling.

That last one was the key reasons. I could have mocked up a fake context to override their version of testing.T, but that felt like a lot of bloat given the other concerns above. So in the end, I just included a slightly modified version with mspec.

Since then, I've found a few small bugs and even a broken test or two with that old testify version. I've also noticed additional comparisons that testify now has.

So, it's time to refresh this package with their latest. And also, review the license to see if it has changed.

@eduncan911 eduncan911 changed the title Refresh testify's implementation of assert tests Refactoring: Refresh testify's implementation of assert tests Jun 23, 2016
@eduncan911 eduncan911 self-assigned this Jun 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant