Skip to content

Commit ee00c5f

Browse files
authored
Merge pull request #1088 from efeone/issue_july_21
fix:Hide Rating field of Employee Feedback Rating table in Appraisal doctype
2 parents 24a241a + abae5a9 commit ee00c5f

3 files changed

Lines changed: 20 additions & 9 deletions

File tree

beams/patches.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,3 +8,4 @@ beams.patches.delete_custom_fields #5-07-2025-
88
beams.patches.set_account_in_cost_subhead #14-02-20250
99
beams.patches.set_company_in_budget_template #20-02-2025
1010
beams.patches.update_budget_for_inr #17-03-2025
11+
beams.patches.delete_property_setter #22-07-2025
Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
import frappe
2+
3+
def execute():
4+
# Define the filter to find the Property Setter
5+
filters = {
6+
"doctype_or_field": "DocField",
7+
"doc_type": "Employee Feedback Rating",
8+
"field_name": "Rating",
9+
"property": "read_only",
10+
"property_type": "Check",
11+
"value": "1"
12+
}
13+
14+
# Find and delete the property setter if it exists
15+
property_setter_name = frappe.db.exists("Property Setter", filters)
16+
if property_setter_name:
17+
frappe.db.delete("Property Setter", {"name": property_setter_name})
18+
frappe.db.commit()

beams/setup.py

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3671,14 +3671,6 @@ def get_property_setters():
36713671
"property_type": "Float",
36723672
"value":1
36733673
},
3674-
{
3675-
"doctype_or_field": "DocField",
3676-
"doc_type": "Employee Feedback Rating",
3677-
"field_name": "Rating",
3678-
"property": "read_only",
3679-
"property_type": "Check",
3680-
"value": 1
3681-
},
36823674
{
36833675
"doctype_or_field": "DocField",
36843676
"doc_type": "Employee Performance Feedback",
@@ -3731,7 +3723,7 @@ def get_property_setters():
37313723
"doctype_or_field": "DocField",
37323724
"doc_type": "Employee Feedback Rating",
37333725
"field_name": "rating",
3734-
"property": "read_only",
3726+
"property": "hidden",
37353727
"property_type": "Check",
37363728
"value": 1
37373729
},

0 commit comments

Comments
 (0)