Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add clip_to_bbox argument #3

Open
egagli opened this issue Apr 15, 2024 · 0 comments
Open

add clip_to_bbox argument #3

egagli opened this issue Apr 15, 2024 · 0 comments

Comments

@egagli
Copy link
Owner

egagli commented Apr 15, 2024

Description

Right now, all functions will automatically clip to the bounding box input. While this is desirable, we should allow the option to not clip. We can create an optional boolean argument clip_to_bbox that will by default (True) clip, and not clip if passed False. I've implemented this for the MODIS_snow class only... so this needs to be added to Sentinel1, Sentinel2, HLS, and possibly the derived products.

Source code

# arg to init
clip_to_bbox=True

# in init
self.clip_to_bbox = clip_to_bbox

# in get_data
if self.clip_to_bbox:
   load_params["bbox"] = self.bbox_gdf.total_bounds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant