Skip to content

Commit 6ce3d08

Browse files
committed
fix: mv eic/key4hep/spack.hcl to base.hcl
1 parent 46bf491 commit 6ce3d08

File tree

3 files changed

+19
-19
lines changed

3 files changed

+19
-19
lines changed

.gitlab-ci.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -274,11 +274,17 @@ base:
274274
- nocache=""
275275
- docker buildx bake ${BUILD_OPTIONS} ${nocache}
276276
--print
277+
--file spack.hcl
278+
--file eic-spack.hcl
279+
--file key4hep-spack.hcl
277280
--file containers/variables.hcl
278281
--file containers/debian/base.hcl
279282
- while !
280283
docker buildx bake ${BUILD_OPTIONS} ${nocache}
281284
--push
285+
--file spack.hcl
286+
--file eic-spack.hcl
287+
--file key4hep-spack.hcl
282288
--file containers/variables.hcl
283289
--file containers/debian/base.hcl
284290
2>&1 | tee build.log
@@ -354,17 +360,11 @@ eic:
354360
- nocache=""
355361
- docker buildx bake ${BUILD_OPTIONS} ${nocache}
356362
--print
357-
--file spack.hcl
358-
--file eic-spack.hcl
359-
--file key4hep-spack.hcl
360363
--file containers/variables.hcl
361364
--file containers/jug/dev.hcl
362365
- while !
363366
docker buildx bake ${BUILD_OPTIONS} ${nocache}
364367
--push
365-
--file spack.hcl
366-
--file eic-spack.hcl
367-
--file key4hep-spack.hcl
368368
--file containers/variables.hcl
369369
--file containers/jug/dev.hcl
370370
2>&1 | tee build.log

containers/debian/base.hcl

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,9 @@ variable "BUILD_IMAGE" { default = "debian_base" }
55
# Variables whose defaults can be overridden on build
66
variable "BASE_IMAGE" { default = null }
77

8+
variable "S3_ACCESS_KEY" { default = null }
9+
variable "S3_SECRET_KEY" { default = null }
10+
811
# docker/metadata-action overrides the following target with tags
912
# but we implement it for use outside docker/metadata-action
1013
target "docker-metadata-action" {
@@ -28,5 +31,15 @@ target "default" {
2831
jobs = jobs
2932
BASE_IMAGE = BASE_IMAGE
3033
BUILD_IMAGE = BUILD_IMAGE
34+
SPACK_ORGREPO = try(SPACK_ORGREPO, null)
35+
SPACK_VERSION = try(SPACK_VERSION, null)
36+
SPACK_CHERRYPICKS = join("\n", try(SPACK_CHERRYPICKS, []))
37+
SPACK_CHERRYPICKS_FILES = join("\n", try(SPACK_CHERRYPICKS_FILES, []))
38+
KEY4HEPSPACK_ORGREPO = try(KEY4HEPSPACK_ORGREPO, null)
39+
KEY4HEPSPACK_VERSION = try(KEY4HEPSPACK_VERSION, null)
40+
EICSPACK_ORGREPO = try(EICSPACK_ORGREPO, null)
41+
EICSPACK_VERSION = try(EICSPACK_VERSION, null)
42+
S3_ACCESS_KEY = S3_ACCESS_KEY
43+
S3_SECRET_KEY = S3_SECRET_KEY
3144
}
3245
}

containers/jug/dev.hcl

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,6 @@ variable "DOCKER_REGISTRY" { default = join("/", concat(compact([CI_REGISTRY, CI
99
variable "BUILDER_IMAGE" { default = "debian_base" }
1010
variable "RUNTIME_IMAGE" { default = "debian_base" }
1111

12-
variable "S3_ACCESS_KEY" { default = null }
13-
variable "S3_SECRET_KEY" { default = null }
14-
1512
variable "NIGHTLY" { default = null }
1613
variable "NIGHTLY_TAG" { default = null }
1714

@@ -64,16 +61,6 @@ target "default" {
6461
BUILDER_IMAGE = BUILDER_IMAGE
6562
RUNTIME_IMAGE = RUNTIME_IMAGE
6663
INTERNAL_TAG = INTERNAL_TAG
67-
SPACK_ORGREPO = try(SPACK_ORGREPO, null)
68-
SPACK_VERSION = try(SPACK_VERSION, null)
69-
SPACK_CHERRYPICKS = join("\n", try(SPACK_CHERRYPICKS, []))
70-
SPACK_CHERRYPICKS_FILES = join("\n", try(SPACK_CHERRYPICKS_FILES, []))
71-
KEY4HEPSPACK_ORGREPO = try(KEY4HEPSPACK_ORGREPO, null)
72-
KEY4HEPSPACK_VERSION = try(KEY4HEPSPACK_VERSION, null)
73-
EICSPACK_ORGREPO = try(EICSPACK_ORGREPO, null)
74-
EICSPACK_VERSION = try(EICSPACK_VERSION, null)
75-
S3_ACCESS_KEY = S3_ACCESS_KEY
76-
S3_SECRET_KEY = S3_SECRET_KEY
7764
EDM4EIC_VERSION = BUILD_TYPE == "default" ? EDM4EIC_VERSION : "main"
7865
EICRECON_VERSION = BUILD_TYPE == "default" ? EICRECON_VERSION : "main"
7966
EPIC_VERSION = BUILD_TYPE == "default" ? EPIC_VERSION : "main"

0 commit comments

Comments
 (0)