Skip to content

Commit c477331

Browse files
authored
Fixed eventType mismatch issue while generating events (#52)
1 parent f8e4416 commit c477331

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

src/main/java/com/ericsson/eiffel/remrem/semantics/SemanticsService.java

+6-6
Original file line numberDiff line numberDiff line change
@@ -149,13 +149,13 @@ public String generateMsg(String msgType, JsonObject bodyJson){
149149
//if input JSON EventType is missing adding query parameter as Type.
150150
String inputEventType = getInputEventType(bodyJson);
151151
if(inputEventType == null || inputEventType.isEmpty()){
152-
bodyJson.get(MSG_PARAMS).getAsJsonObject().get(META).getAsJsonObject().addProperty(TYPE, msgType);
153-
}else if(!(inputEventType.equals(msgType))){
152+
bodyJson.get(MSG_PARAMS).getAsJsonObject().get(META).getAsJsonObject().addProperty(TYPE, eiffelType.getEventName());
153+
}else if(!(inputEventType.equals(eiffelType.getEventName()))){
154154
log.error("check the input json message type : " + inputEventType);
155-
return createErrorResponse(msgType,supportedEventTypes);
155+
return createErrorResponse(eiffelType.getEventName(),"Mismatch of eventype in request query parameter with property 'type' in the input json message");
156156
}
157157

158-
Event event = eventCreation(msgType, eventType, msgNodes, eventNodes);
158+
Event event = eventCreation(eventType, msgNodes, eventNodes);
159159

160160
String result = gson.toJson(event);
161161
try {
@@ -166,9 +166,9 @@ public String generateMsg(String msgType, JsonObject bodyJson){
166166
}
167167
return result;
168168
}
169-
private static Event eventCreation(String msgType, Class<? extends Event> eventType, JsonObject msgNodes,
169+
private static Event eventCreation(Class<? extends Event> eventType, JsonObject msgNodes,
170170
JsonObject eventNodes) {
171-
eventNodes.add("meta", msgNodes.get("meta"));
171+
eventNodes.add("meta", msgNodes.get("meta"));
172172
Event event = createEvent(eventNodes, eventType);
173173
event.setMeta(event.generateMeta(event.getMeta()));
174174
return event;

0 commit comments

Comments
 (0)