#486 - Fix crash when adding facilities to construction queue (#488)

ekolis · web-flow · commit 9376e32c0e73 · 2025-05-20T10:12:21.000-04:00
diff --git a/FrEee.Core.Domain/Objects/Civilization/Orders/ConstructionOrder.cs b/FrEee.Core.Domain/Objects/Civilization/Orders/ConstructionOrder.cs
@@ -102,8 +102,7 @@ private IReference<U> GetModReference<U>(string id)
     {
         // since T is not guaranteed to be a compile time IModObject implementation
         var type = typeof(ModReference<>).MakeGenericType(typeof(U));
-        var r = (IReference<U>)Activator.CreateInstance(type);
-        r.SetPropertyValue("ID", id);
+        var r = (IReference<U>)Activator.CreateInstance(type, id);
         return r;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -102,8 +102,7 @@ private IReference<U> GetModReference<U>(string id)`
`102`	`102`	`{`
`103`	`103`	`// since T is not guaranteed to be a compile time IModObject implementation`
`104`	`104`	`var type = typeof(ModReference<>).MakeGenericType(typeof(U));`
`105`		`- var r = (IReference<U>)Activator.CreateInstance(type);`
`106`		`- r.SetPropertyValue("ID", id);`
	`105`	`+ var r = (IReference<U>)Activator.CreateInstance(type, id);`
`107`	`106`	`return r;`
`108`	`107`	`}`
`109`	`108`