Add component and unit diagnostics for beats receivers #8991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request does not have a backport label. Could you fix it @swiatekm? 🙏
|
# Conflicts: # internal/pkg/agent/application/coordinator/coordinator_test.go # internal/pkg/otel/manager/manager.go
swiatekm
force-pushed
the
feat/otel-diagnostics
branch
from
2fe6d75 to
b28331d
Compare
swiatekm
force-pushed
the
feat/otel-diagnostics
branch
from
1a4c954 to
25657e7
Compare
swiatekm
added
Team:Elastic-Agent-Control-Plane
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
|
@swiatekm should we also backport this to 9.1? |
pierrehilbert
added
the
Team:Elastic-Agent-Data-Plane
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
|
💛 Build succeeded, but was flaky
Failed CI StepsHistory
cc @swiatekm |
pkoutsovasilis
approved these changes
Jul 16, 2025
mergify bot
pushed a commit
that referenced
this pull request
Jul 17, 2025
* Add diagnostics to otel manager # Conflicts: # internal/pkg/agent/application/coordinator/coordinator_test.go # internal/pkg/otel/manager/manager.go * add integration test * Move helper function to allow diagnostic tests to run on Windows * Handle diagnostics errors separately * Centralize locking for config updates * Make tests more explicit * Early exit from diagnostics generation function * Refactor config generation for easier locking (cherry picked from commit ce0519f)
5 tasks
swiatekm
added a commit
that referenced
this pull request
Jul 17, 2025
* Add diagnostics to otel manager # Conflicts: # internal/pkg/agent/application/coordinator/coordinator_test.go # internal/pkg/otel/manager/manager.go * add integration test * Move helper function to allow diagnostic tests to run on Windows * Handle diagnostics errors separately * Centralize locking for config updates * Make tests more explicit * Early exit from diagnostics generation function * Refactor config generation for easier locking (cherry picked from commit ce0519f) Co-authored-by: Mikołaj Świątek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add the ability for the otel manager to output diagnostics for components and units it runs. This PR doesn't add any actual diagnostic content, just the necessary scaffolding and tests.
The filebeat registry and beat metrics will be added in follow-up PRs.
Why is it important?
Beat receivers need to be covered by diagnostics to ensure issues with them can be effectively diagnosed.
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added an entry in./changelog/fragmentsusing the changelog toolHow to test this PR locally
Build the agent, run it with self-monitoring using beats receivers enabled, and collect diagnostics. You should see the expected directories without any files.
Related issues