Revert "Add forcibly argument to test cluster stop node method (#98336)"

This reverts commit 2975f33.

Author: mark-vieira

test/test-clusters/src/main/java/org/elasticsearch/test/cluster/ClusterHandle.java

@@ -34,7 +34,7 @@ public interface ClusterHandle extends Closeable {
      * Stops the node at a given index.
      * @param index of the node to stop
      */
-    void stopNode(int index, boolean forcibly);
+    void stopNode(int index);
 
     /**
      * Restarts the cluster. Effectively the same as calling {@link #stop(boolean)} followed by {@link #start()}

test/test-clusters/src/main/java/org/elasticsearch/test/cluster/DefaultElasticsearchCluster.java

@@ -55,9 +55,9 @@ public void stop(boolean forcibly) {
     }
 
     @Override
-    public void stopNode(int index, boolean forcibly) {
+    public void stopNode(int index) {
         checkHandle();
-        handle.stopNode(index, forcibly);
+        handle.stopNode(index);
     }
 
     @Override

test/test-clusters/src/main/java/org/elasticsearch/test/cluster/local/LocalClusterHandle.java

@@ -76,7 +76,7 @@ public void start() {
     public void stop(boolean forcibly) {
         if (started.getAndSet(false)) {
             LOGGER.info("Stopping Elasticsearch test cluster '{}', forcibly: {}", name, forcibly);
-            execute(() -> nodes.parallelStream().forEach(n -> stopNode(nodes.indexOf(n), forcibly)));
+            execute(() -> nodes.parallelStream().forEach(n -> n.stop(forcibly)));
         } else {
             // Make sure the process is stopped, otherwise wait
             execute(() -> nodes.parallelStream().forEach(Node::waitForExit));
@@ -167,7 +167,7 @@ public long getPid(int index) {
         return nodes.get(index).getPid();
     }
 
-    public void stopNode(int index, boolean forcibly) {
+    public void stopNode(int index) {
         nodes.get(index).stop(false);
     }