Pass secretValues

Author: ycombinator

internal/pkg/policy/parsed_policy.go

@@ -90,7 +90,7 @@ func NewParsedPolicy(ctx context.Context, bulker bulk.Bulk, p model.Policy) (*Pa
 	// FIXME: Replace secrets in 'agent.download' section of policy
 	if agentDownload, exists := p.Data.Agent["download"]; exists {
 		if section, ok := agentDownload.(map[string]interface{}); ok {
-			agentDownloadSecretKeys, err := secret.ProcessAgentDownloadSecrets(ctx, section, bulker)
+			agentDownloadSecretKeys, err := secret.ProcessAgentDownloadSecrets(section, secretValues)
 			if err != nil {
 				return nil, fmt.Errorf("error processing agent secrets: %w", err)
 			}

internal/pkg/secret/secret.go

@@ -379,26 +379,13 @@ func processOutputWithInlineSecrets(output smap.Map, secretValues map[string]str
 }
 
 // ProcessAgentDownloadSecrets reads and replaces secrets in the agent.download section of the policy
-func ProcessAgentDownloadSecrets(ctx context.Context, agentDownload smap.Map, bulker bulk.Bulk) ([]string, error) {
+func ProcessAgentDownloadSecrets(agentDownload smap.Map, secretValues map[string]string) ([]string, error) {
 	secrets := agentDownload.GetMap(FieldSecrets)
 	delete(agentDownload, FieldSecrets)
 
-	secretReferences := make([]model.SecretReferencesItems, 0)
 	agentDownloadSecrets := getSecretIDAndPath(secrets)
 	keys := make([]string, 0, len(agentDownloadSecrets))
 
-	for _, secret := range agentDownloadSecrets {
-		secretReferences = append(secretReferences, model.SecretReferencesItems{
-			ID: secret.ID,
-		})
-	}
-	if len(secretReferences) == 0 {
-		return nil, nil
-	}
-	secretValues, err := GetSecretValues(ctx, secretReferences, bulker)
-	if err != nil {
-		return nil, err
-	}
 	for _, secret := range agentDownloadSecrets {
 		var key string
 		for _, p := range secret.Path {