Use context provided RoomViewStore within the RoomView component hierarchy #31077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update ContentMessages.ts
5 tasks
t3chguy
reviewed
Oct 27, 2025
| member instanceof RoomMember && member.roomId | ||
| ? member.roomId | ||
| : SdkContextClass.instance.roomViewStore.getRoomId(); | ||
| const memberOrRoomRoomId = member instanceof RoomMember && member.roomId ? member.roomId : roomId; |
Member
There was a problem hiding this comment.
I think this identifier is confusing, if anything it should be memberRoomIdOrRoomRoomId but that isn't really better, what was wrong with roomId? Just the clash? Then maybe the receiver should be tweaked to avoid this confusion. Or you could mutate it if (member instanceof RoomMember && member.roomId) roomId = member.roomId;
Member
Author
There was a problem hiding this comment.
Yea it was mainly the clash.
What do you mean by "Then maybe the receiver should be tweaked to avoid this confusion."?
Member
There was a problem hiding this comment.
The parameter name could be fallbackRoomId or something
t3chguy
approved these changes
Oct 27, 2025
…nt-web into langleyd/use-context-rvs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #30980
What's in this PR?
This PR builds upon #30980 updating usages of RoomViewStore within the RoomView sub components to use the instance provided by the context rather than the singleton.
Easiest read commit by commit.