From 889ffd937511c229150ce6f2ee7e3aeafaaa9910 Mon Sep 17 00:00:00 2001 From: Andrew Morgan Date: Tue, 21 Oct 2025 14:29:30 +0100 Subject: [PATCH 1/4] Have the release script warn if a workflow is queued for >15m --- scripts-dev/release.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/scripts-dev/release.py b/scripts-dev/release.py index 391881797e2..1d98820a086 100755 --- a/scripts-dev/release.py +++ b/scripts-dev/release.py @@ -596,6 +596,11 @@ def _wait_for_actions(gh_token: Optional[str]) -> None: if len(resp["workflow_runs"]) == 0: continue + # Warn the user if any workflows are still queued. They might need to fix something. + if any(workflow["status"] == "queued" for workflow in resp["workflow_runs"]): + _notify("Warning: at least one release workflow is still queued...") + continue + if all( workflow["status"] != "in_progress" for workflow in resp["workflow_runs"] ): From 7cd9678e7d66158b225c91ba2e76e20c7e721824 Mon Sep 17 00:00:00 2001 From: Andrew Morgan Date: Tue, 21 Oct 2025 14:31:35 +0100 Subject: [PATCH 2/4] newsfile --- changelog.d/19084.misc | 1 + 1 file changed, 1 insertion(+) create mode 100644 changelog.d/19084.misc diff --git a/changelog.d/19084.misc b/changelog.d/19084.misc new file mode 100644 index 00000000000..4a84262b9fd --- /dev/null +++ b/changelog.d/19084.misc @@ -0,0 +1 @@ +Warn the developer when they are releasing Synapse if a release workflow has been queued for over 15 minutes. \ No newline at end of file From b5c66dea20f4ef5e0fda3ee341290fa52cf2b32a Mon Sep 17 00:00:00 2001 From: Andrew Morgan Date: Fri, 24 Oct 2025 10:36:40 +0100 Subject: [PATCH 3/4] Allow continuing on despite queued assets --- scripts-dev/release.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/scripts-dev/release.py b/scripts-dev/release.py index 1d98820a086..2c55cdd5922 100755 --- a/scripts-dev/release.py +++ b/scripts-dev/release.py @@ -599,6 +599,9 @@ def _wait_for_actions(gh_token: Optional[str]) -> None: # Warn the user if any workflows are still queued. They might need to fix something. if any(workflow["status"] == "queued" for workflow in resp["workflow_runs"]): _notify("Warning: at least one release workflow is still queued...") + if not click.confirm("Continue waiting for queued assets?", default=True): + click.echo("Continuing on with the release. Note that you may need to upload missing assets manually later.") + break continue if all( From 9cd8166843e28949486a9b05d97f93c5ffeaf5ad Mon Sep 17 00:00:00 2001 From: Andrew Morgan Date: Fri, 24 Oct 2025 11:12:25 +0100 Subject: [PATCH 4/4] lint --- scripts-dev/release.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/scripts-dev/release.py b/scripts-dev/release.py index 2c55cdd5922..c2e71e96e2e 100755 --- a/scripts-dev/release.py +++ b/scripts-dev/release.py @@ -600,7 +600,9 @@ def _wait_for_actions(gh_token: Optional[str]) -> None: if any(workflow["status"] == "queued" for workflow in resp["workflow_runs"]): _notify("Warning: at least one release workflow is still queued...") if not click.confirm("Continue waiting for queued assets?", default=True): - click.echo("Continuing on with the release. Note that you may need to upload missing assets manually later.") + click.echo( + "Continuing on with the release. Note that you may need to upload missing assets manually later." + ) break continue