Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement req: sticky stack frame with peek #195

Open
rileyrg opened this issue Jan 19, 2020 · 5 comments
Open

enhancement req: sticky stack frame with peek #195

rileyrg opened this issue Jan 19, 2020 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@rileyrg
Copy link

rileyrg commented Jan 19, 2020

While learning/debugging this particular code framework I find I use the stack frame a lot. I would like to suggest the following enhancements/tweaks.

  1. "As is" it would be nice if the stack frame remembered the last line selected. As it is one has to scroll down quite a lot to the point of interest each time you bring it up.

  2. more ambitious - make the stack frame sticky (option in custom) and also provide a peek facility. In helm for example right arrow would peek the buffer under point but would keep focus in the stack frame.

The new tree windows are a great improvement though the facility to resize the locals pane would be great.

@yyoncho
Copy link
Member

yyoncho commented Jan 19, 2020

Point 2 is relatively easy to be implemented by creating helm extension which I think automatically will support the peek(persistent action). I do not understand point 1 - when you select a stackframe it should point to the correct line. Or you are talking about the sessions view?

@rileyrg
Copy link
Author

rileyrg commented Jan 19, 2020 via email

@yyoncho yyoncho added enhancement New feature or request help wanted Extra attention is needed labels Jan 19, 2020
@yyoncho
Copy link
Member

yyoncho commented Jan 19, 2020

I got it. Since it has relatively low impact, I am not planning to work on this anytime soon, but if you want to give it a try here it is a guide on creating helm interfaces - https://tuhdo.github.io/helm-intro.html .This guide + existing dap-mode functions will be sufficient for you if you want to implement the feature by yourself.

@rileyrg
Copy link
Author

rileyrg commented Jan 19, 2020 via email

@nbfalcon
Copy link
Member

Ivy supports peeking - ivy-call-and-recenter, bound to C-SPC in DOOM. Versions of dap-switch-stack-frame would have to be written for helm and ivy.

@nbfalcon nbfalcon added the good first issue Good for newcomers label Oct 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants