How to make lsp-haskell more loosely tied to haskell-mode?

[magthe]

In my experimenting with making a Haskell mode that uses tree-sitter I ended up having to make some changes to lsp-haskell to detach it from haskell-mode. My very hacky change is here: magthe@2084ff1

I'd love some input on how to do this more properly and turn it into a PR eventually.

[michaelpj]

No idea tbh. Probably a question for @yyoncho ?

I'm not sure what's wrong with just adding haskell-ng-mode to the set of modes that we are enabled for? i.e. just do what is already done for e.g. haskell-literate-mode?

[magthe]

Well, I think it's mostly a question of cleanliness, if lsp-haskell depends on both packages, then both will be installed all the time. Even if it only makes sense to use one or the other, never both.

[michaelpj]

Your patch doesn't make lsp-haskell depend on haskell-ng-mode? Or am I missing something? do we need a dependency? or is that just an elisp symbol for the mode name?

[magthe]

No, it only removes completely the dependency on haskell-mode so I can avoid having it around while working on haskell-ng-mode.

[dschrempf]

I suggest closing this issue. I think it was fixed in #193