Skip to content

Peer-to-peer code reviewΒ #8

Description

@CarlosIgreda

Hi @emarkees,

Good job so far! πŸš€
You still need to work on some issues to improve your code, but you are almost there! πŸ‘Œ

tufoin

Highlights

βœ… No linter errors
βœ… Good use of GitHub Flow
βœ… Commits are descriptive

Required Changes ♻️

  • CSS:

  • Kindly consider creating a CSS rule to group the property display: flex, since it is repeating in other lines.

  • HTML:

  • Kindly consider putting a value in your form action since it shouldn't be empty.
    e.g. <form action="#" class="form">

  • Kindly consider changing your h5 element since the objective of using that is to convey hierarchy and in this case, it is not needed because it's a simple text. You can try the p element instead.
    e.g. <p>Clear all completed</p>

  • JavaScipt:

  • Kindly consider checking your file checkbox.js since there is a function updateLocalStorage and at the moment of declaration, you only use 1 parameter, but in the following line when you call the function, you are using 2 parameters.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this issue. However, I strongly recommend you consider them as they can improve your code.

Cheers, and Happy coding!πŸ‘πŸ‘πŸ‘

Feel free to leave any questions or comments in this issue thread if something is not 100% clear.
Remember to tag me in your question so I can receive the notification.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions