Hi @emarkees,
Good job so far! π
You still need to work on some issues to improve your code, but you are almost there! π

Highlights
β
No linter errors
β
Good use of GitHub Flow
β
Commits are descriptive
Required Changes β»οΈ
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this issue. However, I strongly recommend you consider them as they can improve your code.
Cheers, and Happy coding!πππ
Feel free to leave any questions or comments in this issue thread if something is not 100% clear.
Remember to tag me in your question so I can receive the notification.
Hi @emarkees,
Good job so far! π
You still need to work on some issues to improve your code, but you are almost there! π
Highlights
β No linter errors
β Good use of GitHub Flow
β Commits are descriptive
Required Changes β»οΈ
CSS:
Kindly consider creating a CSS rule to group the property
display: flex, since it is repeating in other lines.HTML:
Kindly consider putting a value in your form action since it shouldn't be empty.
e.g.
<form action="#" class="form">Kindly consider changing your
h5element since the objective of using that is to convey hierarchy and in this case, it is not needed because it's a simple text. You can try thepelement instead.e.g.
<p>Clear all completed</p>JavaScipt:
Kindly consider checking your file checkbox.js since there is a function
updateLocalStorageand at the moment of declaration, you only use 1 parameter, but in the following line when you call the function, you are using 2 parameters.Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this issue. However, I strongly recommend you consider them as they can improve your code.
Cheers, and Happy coding!πππ
Feel free to leave any questions or comments in this issue thread if something is not 100% clear.
Remember to tag me in your question so I can receive the notification.