rnfc: move PICC bytes to enum

Signed-off-by: Krzysztof Królczyk <[email protected]>

Author: kkrolczyk

rnfc-fm175xx/src/iso14443a.rs

@@ -2,6 +2,7 @@ use embassy_futures::yield_now;
 use embassy_time::{Duration, Instant, Timer};
 use embedded_hal::digital::{InputPin, OutputPin};
 use embedded_hal_async::digital::Wait;
+use rnfc::picc_cmds;
 use rnfc_traits::iso14443a_ll as ll;
 
 use crate::fmt::Bytes;
@@ -105,7 +106,7 @@ where
 
         let (tx, crc, timeout_1fc, lastbits, rxalign) = match opts {
             ll::Frame::Anticoll { bits } => (&tx[..(bits + 7) / 8], false, 65536, (bits % 8) as u8, (bits % 8) as u8),
-            ll::Frame::ReqA => (&[0x26][..], false, 16384, 7, 0),
+            ll::Frame::ReqA => (&[picc_cmds::REQA][..], false, 16384, 7, 0),
             ll::Frame::WupA => (&[0x52][..], false, 16384, 7, 0),
             ll::Frame::Standard { timeout_1fc } => (tx, true, timeout_1fc, 0, 0),
         };

rnfc/src/lib.rs

@@ -8,3 +8,4 @@ pub use rnfc_traits as traits;
 
 pub mod iso14443a;
 pub mod iso_dep;
+pub mod picc_cmds;

rnfc/src/picc_cmds.rs

@@ -0,0 +1,50 @@
+/// Both NFC (ISO/IEC 18092) and RFID (ISO/IEC 14443) codes/types collected here
+#[derive(Debug, Clone, Copy, PartialEq)]
+pub enum PiccCodes {
+    /// REQuest command, Type A, moves PICC from IDLE to READY state
+    REQA = 0x26,
+    /// Wake-UP command, Type A, moves PICC from IDLE or HALT to READY
+    WUPA = 0x52,
+    /// REQuest command, Type B, (Requested/slot-maker) ready
+    REQB = 0x05,
+    /// Wake-UP command, Type B
+    WUPB = 0x08,
+    /// With matching PUPI moves PICC to ACTIVE
+    ATTRIB = 0x1D,
+    /// Cascade Tag, UID not complete, used during anti-collision
+    CT = 0x88,
+    /// Anti collision/Select, Cascade Level 1
+    SelCl1 = 0x93,
+    /// Anti collision/Select, Cascade Level 2
+    SelCl2 = 0x95,
+    /// Anti collision/Select, Cascade Level 3
+    SelCl3 = 0x97,
+    /// HaLT command, Type A == Type B, move PICC state to HALT
+    HLT = 0x50,
+    /// Request command for Answer To Select
+    RATS = 0xE0,
+    /// Select, Type B
+    SEL = 0x0E,
+    /// Perform authentication with Key A
+    MfAuthKeyA = 0x60,
+    /// Perform authentication with Key B
+    MfAuthKeyB = 0x61,
+    /// Reads one 16 byte block from the authenticated sector of the PICC.\
+    /// Also used for MIFARE Ultralight.
+    MfRead = 0x30,
+    /// Writes one 16 byte block to the authenticated sector of the PICC.\
+    /// Called "COMPATIBILITY WRITE" for MIFARE Ultralight.
+    MfWrite = 0xA0,
+    /// Decrements the contents of a block and stores the result in the internal data register.
+    MfDecrement = 0xC0,
+    /// Increments the contents of a block and stores the result in the internal data register.
+    MfIncrement = 0xC1,
+    /// Reads the contents of a block into the internal data register.
+    MfRestore = 0xC2,
+    /// Writes the contents of the internal data register to a block.
+    MfTransfer = 0xB0,
+    /// Writes one 4 byte page to the PICC.
+    UlWrite = 0xA2,
+    /// TODO
+    RFU = 0xF8,
+}