Skip to content

Commit 9ecd8a4

Browse files
wycatsNullVoxPopuli
authored andcommitted
Initial implementation of renderComponent
There's more in this commit than there should be, largely because this commit bundles a change to the plugins that fixes lexical scope bugs. I intend to separate those changes out into their own PR before attempting to merge this one. This PR also needs a flag for the new API. Finally this commit adds some new testing infrastructure to generalize the base render tests so it can be used with templates that are not registered into a container. This is useful more generally, and could be used in other places in the test suite in the future. Fix test types
1 parent e1abff5 commit 9ecd8a4

24 files changed

+1120
-318
lines changed

packages/@ember/-internals/glimmer/lib/environment.ts

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,10 @@
11
import { ENV } from '@ember/-internals/environment';
2-
import { get, set, _getProp, _setProp } from '@ember/-internals/metal';
3-
import type { InternalOwner } from '@ember/-internals/owner';
2+
import { _getProp, _setProp, get, set } from '@ember/-internals/metal';
43
import { getDebugName } from '@ember/-internals/utils';
54
import { constructStyleDeprecationMessage } from '@ember/-internals/views';
6-
import { assert, deprecate, warn } from '@ember/debug';
75
import type { DeprecationOptions } from '@ember/debug';
8-
import { schedule, _backburner } from '@ember/runloop';
6+
import { assert, deprecate, warn } from '@ember/debug';
7+
import { _backburner, schedule } from '@ember/runloop';
98
import { DEBUG } from '@glimmer/env';
109
import setGlobalContext from '@glimmer/global-context';
1110
import type { EnvironmentDelegate } from '@glimmer/runtime';
@@ -131,7 +130,7 @@ const VM_ASSERTION_OVERRIDES: { id: string; message: string }[] = [];
131130
export class EmberEnvironmentDelegate implements EnvironmentDelegate {
132131
public enableDebugTooling: boolean = ENV._DEBUG_RENDER_TREE;
133132

134-
constructor(public owner: InternalOwner, public isInteractive: boolean) {}
133+
constructor(public owner: object, public isInteractive: boolean) {}
135134

136135
onTransactionCommit(): void {}
137136
}

0 commit comments

Comments
 (0)