Should we deprecate the default optional features?

[chancancode]

1. Application template wrapper
2. jQuery integration
3. Template-only glimmer components
4. Default async observers

Maybe with the exception of the last one, the rest are relatively easy to migrate (probably the easiest part about the Octane migration), and doesn't really cost the framework a ton to keep them around. On the other hand, it's a possible divergence in an app's setup, so we need to ask additional questions when helping people in Discord, etc.

How would the community feel about deprecating these? I guess I don't really know what the uptake is for these optional features.

Even if we don't deprecate them, we can probably still remove the code at build time if we know they are disabled, so it's not really so much about maintenance burden as it is about cognitive overhead for the community.

[jelhan]

Maybe with the exception of the last one, the rest are relatively easy to migrate (probably the easiest part about the Octane migration)

Migration path for default async observer isn't that complex as long as it only affects the default but does not remove the feature. In that case it's only about explicitly stated that an observer should be async. Or did I missed something?

[Gaurav0]

I think there are quite some applications for which jquery-integration: true is still the setting, even though they are on a post Octane version of Ember.

[chancancode]

@Gaurav0 do you happen to know why? (As opposed to disabling the integration but still using jquery by itself.)

This also doesn’t have to be all-or-nothing. If we think some are more ready than the rest we can do those first. But if we think it would be confusing to do it staged we can probably also wait.

[NullVoxPopuli]

If you were audit CrowdStrike's usage of jQuery after login, you'd see that the remaining jquery usage in the post-octane apps exists only to handle query param formatting.

We want to get rid of it asap, and wouldn't mind the change in defaults. :)

Also, personally, I'm a huge fan of ditching permanently in ember version 4

[Gaurav0]

@chancancode I work with lots of enterprise apps that are large and usually behind the curve. They may have a post Octane version of Ember, but lots of code still looks like Ember 2.x. I think removing for 4.0 will keep some of these apps on 3.x.

[chancancode]

@NullVoxPopuli @Gaurav0 this isn't really about whether apps should use jQuery or not, I don't think Ember has an opinion on that (any more so than whether you should use lodash or whatever), it's specifically about Ember jQuery integration which IIRC is limited to only a few things that has relatively simple/mechanical migration, (e.g. instead of this.$(), import $ from 'jquery'; plus $(this.element). Is that not the case?

@Gaurav0 do you know specifically what feature is being used and what made it difficult to migrate?

[Gaurav0]

Event handlers

[chancancode]

@Gaurav0 Sorry, I am still not fully understanding what specifically you are referring to. Can you be more specific? Can you show some examples?

Also, I just double checked, as far as I can tell, the things enabled by the optional feature are already deprecated for a 4.0 removal. I could totally be reading it wrong, but according to the already accepted (and implemented) RFCs, the flag (if not removed) will do nothing in Ember 4.0. What am I missing?

[simonihmig]

Also, I just double checked, as far as I can tell, the things enabled by the optional feature are already deprecated for a 4.0 removal. I could totally be reading it wrong, but according to the already accepted (and implemented) RFCs, the flag (if not removed) will do nothing in Ember 4.0. What am I missing?

I agree. It's been a while since writing the RFC, but pretty sure that's how it was intended and implemented. So it has already been decided on to basically drop all jQuery related code in Ember 4.0.

Event handlers

According to the RFC, @ember/jquery should take over the responsibility to provide all the jQuery integration features that previously where supported by Ember itself. Including a jQuery-based Event Dispatcher (we basically need to revive this PR: emberjs/ember-jquery#31).

So your jQuery-based Components should continue to work as-is, even with Ember 4.0 dropping jQuery integration, as long as that addon is installed.

[sandstrom]

Good idea!

Need a good migration path for them, and we already have that. When we upgraded to Octane 1-3 was easy. 4 not switched yet, but where not that far away from it.

Deprecating now and removing in 4.0 sounds great.

[wagenet]

I'm closing this due to inactivity. This doesn't mean that the idea presented here is invalid, but that, unfortunately, nobody has taken the effort to spearhead it and bring it to completion. Please feel free to advocate for it if you believe that this is still worth pursuing. Thanks!