Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error with language filter #1390

Open
ozboss opened this issue Nov 11, 2024 · 1 comment
Open

Error with language filter #1390

ozboss opened this issue Nov 11, 2024 · 1 comment
Assignees
Labels
bug A confirmed issues that needs fixing

Comments

@ozboss
Copy link

ozboss commented Nov 11, 2024

Paste the command

npx -y igir@latest link
--input "roms_bugtest"
--dat "No-Intro Love Pack (PC XML) (2024-09-22)/No-Intro/Nintendo - Game Boy Advance (Parent-Clone) (20240910-173950).dat"
--output roms_filtered_bugtest/{onion}/
--filter-language DE,EN
--prefer-language DE
--prefer-region GER,USA,EUR
--symlink
--symlink-relative
--no-bios
--no-unlicensed
--only-retail
--single
--filter-regex-exclude "Virtual Console"
-vvv > igir.log

Describe the bug

The command selects Advance Wars (USA) out of the following available ROMs:

  • Advance Wars (Europe) (En,Fr,De,Es)
  • Advance Wars (Europe) (En,Fr,De,Es) (Virtual Console)
  • Advance Wars (USA)
  • Advance Wars (USA) (Rev 1)
  • Advance Wars (USA) (Virtual Console)

Expected behavior

I would expect --prefer-language to be stronger then --prefer-region and therefore select Advance Wars (Europe) (En,Fr,De,Es).
This is also how it is described in the docs:

Multiple --prefer-* options can be specified at once, and they will be applied in the following order of importance (most important to least important).

Here --prefer-language is above --prefer-region.

Debug logs

igir.log
Nintendo - Game Boy Advance (Parent-Clone) (20240910-173950).dat.txt

DAT(s) used

No response

igir version

v3.0.1

Node.js version

v22.4.1

Operating system

Fedora 41

Additional context

No response

@ozboss ozboss added the potential-bug A potential issue that needs confirmation and/or triage label Nov 11, 2024
@emmercm emmercm added bug A confirmed issues that needs fixing and removed potential-bug A potential issue that needs confirmation and/or triage labels Feb 14, 2025
@emmercm
Copy link
Owner

emmercm commented Feb 14, 2025

This is definitely wrong, and it's the same root issue as #1392.

@emmercm emmercm self-assigned this Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A confirmed issues that needs fixing
Projects
None yet
Development

No branches or pull requests

2 participants