Skip to content

Commit 01e2dad

Browse files
authored
fix: improve error handling
CHL-1373: Python SDK - Improve error handling
2 parents d0a4b76 + f0ff952 commit 01e2dad

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

emnify/api_manager.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,8 @@ class BaseApiManager:
2020
201: 'return_success',
2121
401: 'unauthorised',
2222
204: 'return_success',
23-
409: 'process_exception'
23+
409: 'process_exception',
24+
422: 'process_exception'
2425
}
2526

2627
request_url_prefix = ''

emnify/errors.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010

1111

1212
class EMnifyBaseException(Exception):
13-
"""Cumstom base error class"""
13+
"""Custom base error class"""
1414

1515

1616
class UnauthorisedException(EMnifyBaseException):

emnify/modules/device/api_call_manager.py

+2-3
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ class GetAllDevicesApiCall(BaseApiManager):
1616
class GetEventsByDevice(BaseApiManager):
1717
request_url_prefix = '/v1/endpoint/{endpoint_id}/event'
1818
request_method_name = RequestsType.GET.value
19+
1920
def __init__(self, *args, **kwargs):
2021
super().__init__(*args, **kwargs)
2122
self.response_handlers = self.response_handlers.copy() | {
@@ -33,9 +34,6 @@ class CreateDevice(BaseApiManager):
3334
422: 'process_exception'
3435
}
3536

36-
def process_exception(self, response: requests.Response, client, data: dict = None, *args, **kwargs):
37-
raise ValidationErrorException(f'{response.json()}')
38-
3937
def return_success(self, response: requests.Response, client, data: dict = None, *args, **kwargs) -> True:
4038
return int(response.headers.get('Location').split('/')[-1])
4139

@@ -65,6 +63,7 @@ class UpdateDevice(BaseApiManager):
6563
response_handlers = {
6664
204: 'return_success',
6765
401: 'unauthorised',
66+
422: 'process_exception'
6867
}
6968

7069

emnify/modules/device/models.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ class UpdateDevice(generated_models.UpdateEndpointrequest):
129129
name: str = None
130130
tags: str = None
131131
status: generated_models.Status = None
132-
service_profile: Dict[str, Any] = None
132+
service_profile: generated_models.ServiceProfile1 = None
133133
tariff_profile: Dict[str, Any] = None
134134
ip_address: str = None
135135
ip_address_space: Dict[str, Any] = None

0 commit comments

Comments
 (0)