Cleanup based on analysis by https://lgtm.com (knex#2870)

* Cleanup based on analysis by https://lgtm.com

* Fix linting

Author: kibertoad

.eslintrc.js

@@ -1,4 +1,4 @@
-var warning = process.env['CI'] ? 2 : 1;
+const warning = process.env['CI'] ? 2 : 1;
 
 module.exports = {
   parser: 'babel-eslint',

lgtm.yml

@@ -0,0 +1,3 @@
+path_classifiers:
+  test:
+  - scripts

package.json

@@ -43,7 +43,7 @@
     "chai": "^4.2.0",
     "chai-subset-in-order": "^2.1.2",
     "coveralls": "^3.0.2",
-    "eslint": "5.6.1",
+    "eslint": "5.7.0",
     "eslint-config-prettier": "^3.1.0",
     "eslint-plugin-import": "^2.14.0",
     "husky": "^1.1.1",
@@ -59,7 +59,7 @@
     "pg-query-stream": "^1.1.2",
     "prettier": "^1.14.3",
     "rimraf": "^2.6.2",
-    "sinon": "^6.3.5",
+    "sinon": "^7.0.0",
     "sinon-chai": "^3.2.0",
     "source-map-support": "^0.5.9",
     "sqlite3": "^4.0.2",

src/dialects/mssql/index.js

@@ -251,8 +251,7 @@ assign(Client_MSSQL.prototype, {
 
   // Grab a connection, run the query via the MSSQL streaming interface,
   // and pass that through to the stream we've sent back to the client.
-  _stream(connection, obj, stream, options) {
-    options = options || {};
+  _stream(connection, obj, stream) {
     if (!obj || typeof obj === 'string') obj = { sql: obj };
     return new Promise((resolver, rejecter) => {
       stream.on('error', (err) => {

src/dialects/mysql2/transaction.js

@@ -14,7 +14,7 @@ assign(Transaction_MySQL2.prototype, {
         (err) => err.code === 'ER_SP_DOES_NOT_EXIST',
         () => {
           this.trxClient.logger.warn(
-            'Transaction was implicitly committed, do not mix transactions and' +
+            'Transaction was implicitly committed, do not mix transactions and ' +
               'DDL with MySQL (#805)'
           );
         }

src/dialects/oracle/query/compiler.js

@@ -184,7 +184,7 @@ assign(QueryCompiler_Oracle.prototype, {
     }
 
     // always wrap returning argument in array
-    if (returning && !Array.isArray(returning)) {
+    if (!Array.isArray(returning)) {
       returning = [returning];
     }
 

src/dialects/oracledb/query/compiler.js

@@ -19,7 +19,7 @@ _.assign(Oracledb_Compiler.prototype, {
       this.single.returning
     );
     const outBinding = outBindPrep.outBinding;
-    let returning = outBindPrep.returning;
+    const returning = outBindPrep.returning;
     const insertValues = outBindPrep.values;
 
     if (
@@ -160,8 +160,6 @@ _.assign(Oracledb_Compiler.prototype, {
 
     sql.outBinding = outBinding;
     if (returning[0] === '*') {
-      returning = returning.slice(0, -1);
-
       // Generate select statement with special order by
       // to keep the order because 'in (..)' may change the order
       sql.returningSql = function() {

src/raw.js

@@ -146,10 +146,9 @@ function replaceRawArrBindings(raw, formatter) {
 
 function replaceKeyBindings(raw, formatter) {
   const values = raw.bindings;
-  let { sql } = raw;
-
   const regex = /\\?(:(\w+):(?=::)|:(\w+):(?!:)|:(\w+))/g;
-  sql = raw.sql.replace(regex, function(match, p1, p2, p3, p4) {
+
+  const sql = raw.sql.replace(regex, function(match, p1, p2, p3, p4) {
     if (match !== p1) {
       return p1;
     }