Fix pyodbc port mapping into server

Author: tarsil

.github/workflows/test-suite.yml

@@ -11,6 +11,8 @@ jobs:
   tests:
     name: "Python ${{ matrix.python-version }}"
     runs-on: "ubuntu-latest"
+    env:
+      MSSQL_SA_PASSWORD: Mssql123$#mssql
 
     strategy:
       matrix:
@@ -41,7 +43,7 @@ jobs:
       mssql:
         image: mcr.microsoft.com/mssql/server:2019-GA-ubuntu-16.04
         env:
-          MSSQL_SA_PASSWORD: "Mssql123$#mssql"
+          MSSQL_SA_PASSWORD: ${{ env.MSSQL_SA_PASSWORD }}
           ACCEPT_EULA: "Y"
           MSSQL_PID: Express
         ports:
@@ -80,7 +82,7 @@ jobs:
             postgresql://username:password@localhost:5432/testsuite,
             postgresql+aiopg://username:[email protected]:5432/testsuite,
             postgresql+asyncpg://username:password@localhost:5432/testsuite,
-            mssql://sa:Mssql123$#mssql@localhost:1433/master?driver=ODBC+Driver+17+for+SQL+Server,
-            mssql+pyodbc://sa:Mssql123$#mssql@localhost:1433/master?driver=ODBC+Driver+17+for+SQL+Server,
-            mssql+aioodbc://sa:Mssql123$#mssql@localhost:1433/master?driver=ODBC+Driver+17+for+SQL+Server
+            mssql://sa:Mssql123$#mssql@127.0.0.1:1433/master?driver=ODBC+Driver+17+for+SQL+Server,
+            mssql+pyodbc://sa:Mssql123$#mssql@127.0.0.1:1433/master?driver=ODBC+Driver+17+for+SQL+Server,
+            mssql+aioodbc://sa:Mssql123$#mssql@127.0.0.1:1433/master?driver=ODBC+Driver+17+for+SQL+Server
         run: "scripts/test"

databases/backends/mssql.py

@@ -78,7 +78,7 @@ async def connect(self) -> None:
         user = self._database_url.username or getpass.getuser()
         password = self._database_url.password
 
-        dsn = f"Driver={driver};Database={database};Server={hostname};UID={user};PWD={password};Port={port}"
+        dsn = f"Driver={driver};Database={database};Server={hostname},{port};UID={user};PWD={password};"
 
         self._pool = await aioodbc.create_pool(
             dsn=dsn,