Scrud core #1
Open
Scrud core #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are untouched after generation.
It avoids this error: > last scrud-android-sample/android:manifest-path java.lang.RuntimeException: android:versionCode should not be defined in template at scala.sys.package$.error(package.scala:27) at AndroidManifestGenerator$$anonfun$generateManifestTask$1.apply(AndroidManifestGenerator.scala:16) at AndroidManifestGenerator$$anonfun$generateManifestTask$1.apply(AndroidManifestGenerator.scala:11) at sbt.Scoped$$anonfun$hf5$1.apply(Structure.scala:581) at sbt.Scoped$$anonfun$hf5$1.apply(Structure.scala:581) at scala.Function1$$anonfun$compose$1.apply(Function1.scala:49) at sbt.Scoped$Reduced$$anonfun$combine$1$$anonfun$apply$12.apply(Structure.scala:311) at sbt.Scoped$Reduced$$anonfun$combine$1$$anonfun$apply$12.apply(Structure.scala:311) at sbt.$tilde$greater$$anonfun$$u2219$1.apply(TypeFunctions.scala:41) at sbt.std.Transform$$anon$5.work(System.scala:71)
Also made CursorField able to read from ContentValues.
…None. Includes fixing SQLitePersistenceFactorySpec.
Also made PersistenceFactory an abstract class instead of a trait for performance.
…tead of being one.
This will enable adding missing columns.
This will help with the PersistenceFactory wrapping a ContentResolver to have the correct values for canSave, canCreate, canDelete, etc.
This is a prerequisite to enabling ContentResolverPersistenceFactory.
Bias using PersistenceFactoryMapping over CrudApplication. This prepares for recognizing that applications can have more than one set of EntityTypes.
Also flesh out the scrud model significantly.
This clarifies what is happening.
See ScrudExamplesSpec.
Code that needs data should read it from a cache, which should be at least as efficient, and seems more RESTful. It also simplifies the model more.
Code that needs availableActions should ask the EntityNavigation. This simplifies the model more and reduces the number of instantiations needed.
Instead, if an ActionKey's actionDataTypeOpt is defined, then the platform should present the user with data in fields that have the given ActionDataType, allowing data modification before invoking the action.
This might be resurrected later, but they're adding way too much complexity at this time to get scrud-android working again.
It will later be wrapped into a CopyContext and passed into AdaptedField and SourceField.
This allows the caller to know why it wasn't converted.
Also rename StringConvertibleQT.convertToEditString to convertToString. This enables using convertToString for persistence conversions as well.
scrud-core at least still compiles.
This also fixes scrud-core to pass its tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is simply a place to put review comments. Please don't actually merge it in until scrud-android has been cleaned up.