Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Split logic of SnakeModePolymerBondRenderer by several classes #5497

Open
DmitriiP-EPAM opened this issue Sep 11, 2024 · 1 comment · Fixed by #5498 or #6819 · May be fixed by #6033 or #6756
Open

Refactor: Split logic of SnakeModePolymerBondRenderer by several classes #5497

DmitriiP-EPAM opened this issue Sep 11, 2024 · 1 comment · Fixed by #5498 or #6819 · May be fixed by #6033 or #6756
Assignees
@DmitriiP-EPAM
Labels
refactor Code refactoring, without changing the functionality technical debt
Milestone
Ketcher 3.4.0-rc....

Comments

@DmitriiP-EPAM
Copy link
Collaborator

DmitriiP-EPAM commented Sep 11, 2024 •
edited
Loading

Create:

  • SnakeModeBackboneBondRenderer (black “snake” line)
  • SnakeModeSideChainBondRenderer (blue “snake” line)
  • SnakeModeRNABaseAndSugarBondRenderer (black straight line)

Next step after #5128
@DmitriiP-EPAM DmitriiP-EPAM self-assigned this Sep 11, 2024
@DmitriiP-EPAM DmitriiP-EPAM moved this from To do to In progress in Technical Debt Sep 11, 2024
DmitriiP-EPAM added a commit that referenced this issue Sep 11, 2024
@DmitriiP-EPAM
#5497 – Refactor (Connection.ts): Specify the types
dfdea0a
DmitriiP-EPAM added a commit that referenced this issue Sep 11, 2024
@DmitriiP-EPAM
#5497 – Refactor (Connection.ts): Rename xOffset
33540e3
@DmitriiP-EPAM DmitriiP-EPAM linked a pull request Sep 11, 2024 that will close this issue
#5497 – Refactor: Specify the types of classes for SnakeModePolymerBondRenderer #5498
Merged
13 tasks
DmitriiP-EPAM added a commit that referenced this issue Sep 12, 2024
@DmitriiP-EPAM
#5497 – Refactor (SnakeModePolymerBondRenderer.ts): Specify the types
b7a4ae8
DmitriiP-EPAM added a commit that referenced this issue Sep 12, 2024
@DmitriiP-EPAM
#5497 – Refactor (Connection.ts): Specify the types (amend)
f7ee479
DmitriiP-EPAM added a commit that referenced this issue Sep 12, 2024
@DmitriiP-EPAM
Revert "#5497 – Refactor (Connection.ts): Rename xOffset"
aaf6402 
This reverts commit 33540e3.
DmitriiP-EPAM added a commit that referenced this issue Sep 12, 2024
@DmitriiP-EPAM
#5497 – Refactor (SnakeModePolymerBondRenderer.ts): Specify the types…
c3d208e 
…, refactor the calculation of `endOfPathPart`
DmitriiP-EPAM added a commit that referenced this issue Sep 12, 2024
@DmitriiP-EPAM
#5497 – Refactor (CanvasMatrix.ts): Specify the types
4f9eeb8
DmitriiP-EPAM added a commit that referenced this issue Sep 12, 2024
@DmitriiP-EPAM
#5497 – Refactor (CanvasMatrix.ts): Use new Connection(6)
ca58260
DmitriiP-EPAM added a commit that referenced this issue Sep 13, 2024
@DmitriiP-EPAM
#5497 – Refactor (Connection.ts): Rename xOffset
49fb5f1
DmitriiP-EPAM added a commit that referenced this issue Sep 13, 2024
@DmitriiP-EPAM
#5497 – Refactor (SnakeModePolymerBondRenderer.ts): Change FIXME text
bfec6da
DmitriiP-EPAM added a commit that referenced this issue Sep 13, 2024
@DmitriiP-EPAM
#5497 – Refactor (Connection.ts): Rename `ConnectionDirectionInDegree…
fb6b2eb 
…s`, `ConnectionDirectionOfLastCell`
@DmitriiP-EPAM DmitriiP-EPAM moved this from In progress to In review in Technical Debt Sep 19, 2024
rrodionov91 pushed a commit that referenced this issue Oct 10, 2024
@DmitriiP-EPAM
#5497 – Refactor: Specify the types of classes for `SnakeModePolymerB…
94e546c 
…ondRenderer` (#5498)

* #5497 – Refactor (Connection.ts): Specify the types

* #5497 – Refactor (Connection.ts): Rename `xOffset`

* #5497 – Refactor (SnakeModePolymerBondRenderer.ts): Specify the types

* #5497 – Refactor (Connection.ts): Specify the types (amend)

* Revert "#5497 – Refactor (Connection.ts): Rename `xOffset`"

This reverts commit 33540e3.

* #5497 – Refactor (SnakeModePolymerBondRenderer.ts): Specify the types, refactor the calculation of `endOfPathPart`

* #5497 – Refactor (CanvasMatrix.ts): Specify the types

* #5497 – Refactor (CanvasMatrix.ts): Use `new Connection(6)`

* #5497 – Refactor (Connection.ts): Rename `xOffset`

* #5497 – Refactor (SnakeModePolymerBondRenderer.ts): Change `FIXME` text

* #5497 – Refactor (Connection.ts): Rename `ConnectionDirectionInDegrees`, `ConnectionDirectionOfLastCell`
@github-project-automation github-project-automation bot moved this from In review to Done in Technical Debt Oct 10, 2024
rrodionov91 pushed a commit that referenced this issue Oct 13, 2024
@DmitriiP-EPAM @rrodionov91
#5497 – Refactor: Specify the types of classes for `SnakeModePolymerB…
d9d1f37 
…ondRenderer` (#5498)

* #5497 – Refactor (Connection.ts): Specify the types

* #5497 – Refactor (Connection.ts): Rename `xOffset`

* #5497 – Refactor (SnakeModePolymerBondRenderer.ts): Specify the types

* #5497 – Refactor (Connection.ts): Specify the types (amend)

* Revert "#5497 – Refactor (Connection.ts): Rename `xOffset`"

This reverts commit 33540e3.

* #5497 – Refactor (SnakeModePolymerBondRenderer.ts): Specify the types, refactor the calculation of `endOfPathPart`

* #5497 – Refactor (CanvasMatrix.ts): Specify the types

* #5497 – Refactor (CanvasMatrix.ts): Use `new Connection(6)`

* #5497 – Refactor (Connection.ts): Rename `xOffset`

* #5497 – Refactor (SnakeModePolymerBondRenderer.ts): Change `FIXME` text

* #5497 – Refactor (Connection.ts): Rename `ConnectionDirectionInDegrees`, `ConnectionDirectionOfLastCell`
Guch1g0v pushed a commit that referenced this issue Oct 17, 2024
@DmitriiP-EPAM @Guch1g0v
#5497 – Refactor: Specify the types of classes for `SnakeModePolymerB…
07e9f52 
…ondRenderer` (#5498)

* #5497 – Refactor (Connection.ts): Specify the types

* #5497 – Refactor (Connection.ts): Rename `xOffset`

* #5497 – Refactor (SnakeModePolymerBondRenderer.ts): Specify the types

* #5497 – Refactor (Connection.ts): Specify the types (amend)

* Revert "#5497 – Refactor (Connection.ts): Rename `xOffset`"

This reverts commit 33540e3.

* #5497 – Refactor (SnakeModePolymerBondRenderer.ts): Specify the types, refactor the calculation of `endOfPathPart`

* #5497 – Refactor (CanvasMatrix.ts): Specify the types

* #5497 – Refactor (CanvasMatrix.ts): Use `new Connection(6)`

* #5497 – Refactor (Connection.ts): Rename `xOffset`

* #5497 – Refactor (SnakeModePolymerBondRenderer.ts): Change `FIXME` text

* #5497 – Refactor (Connection.ts): Rename `ConnectionDirectionInDegrees`, `ConnectionDirectionOfLastCell`
@AlexeyGirin
Copy link
Collaborator

No testing required

DmitriiP-EPAM added a commit that referenced this issue Dec 3, 2024
@DmitriiP-EPAM
#5497 – Refactor (SnakeModePolymerBondRenderer): Refactor `generateBe…
94e5c71 
…nd(4)`
DmitriiP-EPAM added a commit that referenced this issue Dec 3, 2024
@DmitriiP-EPAM
#5497 – Refactor (SnakeModeHydrogenBondRenderer): Refactor `generateB…
d6e6dd7 
…end(4)`
DmitriiP-EPAM added a commit that referenced this issue Dec 3, 2024
@DmitriiP-EPAM
#5497 – Refactor (BaseRenderer.ts): Create selectionElement
1dcc4b1
DmitriiP-EPAM added a commit that referenced this issue Mar 25, 2025
@DmitriiP-EPAM
#5497 – Refactor (SideChainConnectionBondRenderer): Create and use `g…
70b8f1e 
…enerateAbsoluteLine(2)`
DmitriiP-EPAM added a commit that referenced this issue Mar 25, 2025
@DmitriiP-EPAM
#5497 – Refactor (SVGPathDAttributeUtil): Create and use the util
cc4e65e
DmitriiP-EPAM added a commit that referenced this issue Mar 25, 2025
@DmitriiP-EPAM
#5497 – Refactor (SVGPathDAttributeUtil): Create and use `generateMov…
887f68c 
…eTo(2)`
DmitriiP-EPAM added a commit that referenced this issue Mar 25, 2025
@DmitriiP-EPAM
#5497 – Refactor (SideChainConnectionBondRenderer): Create and use `c…
55bbea0 
…heckIfConnectionIsStraightVertical(2)`
DmitriiP-EPAM added a commit that referenced this issue Mar 25, 2025
@DmitriiP-EPAM
#5497 – Refactor (SideChainConnectionBondRenderer): Create and use `c…
336bc60 
…alculateSinForYDirection(1)`
DmitriiP-EPAM added a commit that referenced this issue Mar 25, 2025
@DmitriiP-EPAM
#5497 – Refactor (SnakeModePolymerBondRenderer): Reorganize the fragm…
2e9a219 
…ents
DmitriiP-EPAM added a commit that referenced this issue Mar 25, 2025
@DmitriiP-EPAM
#5497 – Refactor (SideChainConnectionBondRenderer): Create and use `g…
f1fd188 
…eneratePathPartForCellsWhichAreOnSameRow(1)`
DmitriiP-EPAM added a commit that referenced this issue Mar 25, 2025
@DmitriiP-EPAM
#5497 – Refactor (SideChainConnectionBondRenderer): Rename `#calculat…
804bc57 
…eSinForYDirection(1)`
DmitriiP-EPAM added a commit that referenced this issue Mar 25, 2025
@DmitriiP-EPAM
#5497 – Refactor (SideChainConnectionBondRenderer): Create and use `g…
ea68bd0 
…eneratePathPartForLastCellIfConnectionIsNotStraightVertical(1)`
DmitriiP-EPAM added a commit that referenced this issue Mar 25, 2025
@DmitriiP-EPAM
#5497 – Refactor (SnakeModePolymerBondRenderer): Use Math.max
91d503f
DmitriiP-EPAM added a commit that referenced this issue Mar 25, 2025
@DmitriiP-EPAM
#5497 – Refactor (SideChainConnectionBondRenderer): Create and use `e…
e65b95d 
…xtractStartAndEndPositionsFromScaledPosition(1)`
DmitriiP-EPAM added a commit that referenced this issue Mar 25, 2025
@DmitriiP-EPAM
#5497 – Refactor (SnakeModePolymerBondRenderer): Reorganize the fragm…
e42e30d 
…ents
DmitriiP-EPAM added a commit that referenced this issue Mar 25, 2025
@DmitriiP-EPAM
#5497 – Refactor (SideChainConnectionBondRendererUtil): Rename the class
ec7757d
@DmitriiP-EPAM DmitriiP-EPAM linked a pull request Mar 25, 2025 that will close this issue
#5497 – Refactor (SnakeModePolymerBondRenderer): Create SnakeModeSideChainBondRenderer #6756
Open
9 tasks
DmitriiP-EPAM added a commit that referenced this issue Apr 2, 2025
@DmitriiP-EPAM
#5497 – Refactor (types.ts): Rename Datum
8b0728e
DmitriiP-EPAM added a commit that referenced this issue Apr 2, 2025
@DmitriiP-EPAM
#5497 – Refactor (SnakeModePolymerBondRenderer / helpers.ts): Refacto…
79d0947 
…r `generateBend(4)`
DmitriiP-EPAM added a commit that referenced this issue Apr 2, 2025
@DmitriiP-EPAM
#5497 – Docs (BaseRenderer.ts): Add the comment
e484af7
DmitriiP-EPAM added a commit that referenced this issue Apr 2, 2025
@DmitriiP-EPAM
#5497 – Docs (SnakeModePolymerBondRenderer): Change the comment
f3ec504
DmitriiP-EPAM added a commit that referenced this issue Apr 2, 2025
@DmitriiP-EPAM
#5497 – Refactor (SnakeModePolymerBondRenderer): Rename `pathDAttribu…
eb1eb31 
…teValue`
DmitriiP-EPAM added a commit that referenced this issue Apr 2, 2025
@DmitriiP-EPAM
#5497 – Refactor (SnakeModePolymerBondRenderer): Rename horizontal
dd93cf3
DmitriiP-EPAM added a commit that referenced this issue Apr 2, 2025
@DmitriiP-EPAM
#5497 – Refactor (SnakeModePolymerBondRenderer): Reorganize `drawPart…
2dbf353 
…OfSideConnection(1)`
DmitriiP-EPAM added a commit that referenced this issue Apr 2, 2025
@DmitriiP-EPAM
#5497 – Refactor (helpers.ts): Shorten generateBend(4)
eae70d9
DmitriiP-EPAM added a commit that referenced this issue Apr 2, 2025
@DmitriiP-EPAM
#5497 – Refactor (SnakeModePolymerBondRenderer): Create and use `SVGP…
b6145ed 
…athDAttributeUtil`
DmitriiP-EPAM added a commit that referenced this issue Apr 2, 2025
@DmitriiP-EPAM
#5497 – Refactor (PolymerBondRenderer): Create and use `PolymerBondRe…
8a82121 
…ndererStartAndEndPositions`
DmitriiP-EPAM added a commit that referenced this issue Apr 2, 2025
@DmitriiP-EPAM
#5497 – Refactor (helpers): Create and use `SVGPathDAttributeUtil.gen…
f04d0c0 
…erateQuadraticRelativeCurve(4)`
DmitriiP-EPAM added a commit that referenced this issue Apr 3, 2025
@DmitriiP-EPAM
#5497 – Refactor, Bugfix (SVGPathDAttributeUtil): Delete the space in…
90fb63d 
… `generateQuadraticRelativeCurve(4)`
rrodionov91 pushed a commit that referenced this issue Apr 3, 2025
@DmitriiP-EPAM
#5497 – Refactor (SnakeModePolymerBondRenderer): Create and use `SVGP…
f271e55 
…athDAttributeUtil` (#6819)

* #5497 – Refactor (types.ts): Rename `Datum`

* #5497 – Refactor (SnakeModePolymerBondRenderer / helpers.ts): Refactor `generateBend(4)`

* #5497 – Docs (BaseRenderer.ts): Add the comment

* #5497 – Docs (SnakeModePolymerBondRenderer): Change the comment

* #5497 – Refactor (SnakeModePolymerBondRenderer): Rename `pathDAttributeValue`

* #5497 – Refactor (SnakeModePolymerBondRenderer): Rename `horizontal`

* #5497 – Refactor (SnakeModePolymerBondRenderer): Reorganize `drawPartOfSideConnection(1)`

* #5497 – Refactor (helpers.ts): Shorten `generateBend(4)`

* #5497 – Refactor (SnakeModePolymerBondRenderer): Create and use `SVGPathDAttributeUtil`

* #5497 – Refactor (PolymerBondRenderer): Create and use `PolymerBondRendererStartAndEndPositions`

* #5497 – Refactor (helpers): Create and use `SVGPathDAttributeUtil.generateQuadraticRelativeCurve(4)`

* #5497 – Refactor, Bugfix (SVGPathDAttributeUtil): Delete the space in `generateQuadraticRelativeCurve(4)`
@rrodionov91 rrodionov91 linked a pull request Apr 3, 2025 that will close this issue
#5497 – Refactor (SnakeModePolymerBondRenderer): Create and use SVGPathDAttributeUtil #6819
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DmitriiP-EPAM DmitriiP-EPAM

Labels
refactor Code refactoring, without changing the functionality technical debt
Projects
Technical Debt
Status: In progress
Milestone
Ketcher 3.4.0-rc.1 (Current)
4 participants
@svvald @rrodionov91 @AlexeyGirin @DmitriiP-EPAM