Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect numbering in sequence mode when adding Phosphates #6584

Open
Zhirnoff opened this issue Feb 28, 2025 · 1 comment · May be fixed by #6668
Open

Incorrect numbering in sequence mode when adding Phosphates #6584

Zhirnoff opened this issue Feb 28, 2025 · 1 comment · May be fixed by #6668
Assignees
Labels
Priority: High Sequence mode Bucket: Sequence mode related issues Severity: High High level visibility to the user User`s Feedback

Comments

@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Feb 28, 2025

Description:
In Sequence mode, when a Phosphates is added to the sequence, the numbering does not restart. Instead, the numbering continues from the previous sequence. This behavior is inconsistent and may lead to confusion when constructing macromolecular structures. The numbering should reset for new components like Phosphates to clearly differentiate them from the main sequence.

Steps to Reproduce

  1. Open Ketcher in Macro mode and switch to Sequence mode.
  2. Create an RNA or DNA sequence.
  3. Add a Phosphates to the sequence.
  4. Observe the numbering of the added component.

Actual behavior
The numbering continues from the previous sequence, creating a lack of differentiation between the main sequence and the newly added components.

Also, phosphates at the beginning/end of the chain get counted.

Expected behavior
The adding of Phosphates should start new count, indicating that they are separate entities from the existing sequence.

Terminal phosphates should not get counted.

Screenshots
Sequence mode

Image

Snake mode

Image

Counting of terminal phosphates

Image

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 131.0.6778.205 (Official Build) (64-bit)

Ketcher version
[Version 3.1.0-rc.6]
Indigo version
[Version 1.29.0-rc.1]
The bug was created as an addition to #6288 because this functionality wasn't fixed and requires updating a large number of screenshots.

@Zhirnoff Zhirnoff added Priority: High Sequence mode Bucket: Sequence mode related issues Severity: High High level visibility to the user User`s Feedback labels Feb 28, 2025
@Zhirnoff Zhirnoff added this to the Ketcher 3.3.0-rc.1 milestone Feb 28, 2025
@AlexeyGirin
Copy link
Collaborator

Moved to 3.2 rc2 after grooming

@rrodionov91 rrodionov91 assigned Ziprion and lmhs and unassigned Ziprion Mar 7, 2025
@lmhs lmhs linked a pull request Mar 12, 2025 that will close this issue
9 tasks
@lmhs lmhs linked a pull request Mar 19, 2025 that will close this issue
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: High Sequence mode Bucket: Sequence mode related issues Severity: High High level visibility to the user User`s Feedback
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants