Skip to content

Commit 8dab916

Browse files
authored
GitLab CI updates (#2070)
increase lassen gpu test time time ci commands do not fail pipeline if job is not found
1 parent fc4fbb2 commit 8dab916

File tree

4 files changed

+42
-40
lines changed

4 files changed

+42
-40
lines changed

.gitlab/LC/.gitlab-ci.yml

+1
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,7 @@ lassen_gcc_12_2_1:
7979

8080
lassen_gcc_12_2_1_cuda:
8181
variables:
82+
ALLOC_TIME: 90
8283
MODULE_LIST: cmake/3.23.1 gcc/12.2.1 cuda/12.2.2
8384
ERF_ENABLE_CUDA: "ON"
8485
# NOTE: c++ and cc are used here over mpicxx/mpicc due to cmake issue finding mpi with cuda?

.gitlab/LC/gitlab_test.sh

+39-38
Original file line numberDiff line numberDiff line change
@@ -47,19 +47,19 @@ then
4747
cd "${build_dir}_cpu"
4848
pwd
4949

50-
cmake -DCMAKE_INSTALL_PREFIX:PATH=./install \
51-
-DCMAKE_CXX_COMPILER:STRING=${CMAKE_CXX_COMPILER:-"mpicxx"} \
52-
-DCMAKE_C_COMPILER:STRING=${CMAKE_C_COMPILER:-"mpicc"} \
53-
-DCMAKE_Fortran_COMPILER:STRING=${CMAKE_Fortran_COMPILER:-"mpifort"} \
54-
-DCMAKE_BUILD_TYPE:STRING=Release \
55-
-DERF_DIM:STRING=3 \
56-
-DERF_ENABLE_MPI:BOOL=ON \
57-
-DERF_ENABLE_CUDA:BOOL=OFF \
58-
-DERF_ENABLE_TESTS:BOOL=OFF \
59-
-DERF_ENABLE_FCOMPARE:BOOL=ON \
60-
-DERF_ENABLE_DOCUMENTATION:BOOL=OFF \
61-
-DCMAKE_EXPORT_COMPILE_COMMANDS:BOOL=ON ..
62-
make -j fcompare
50+
time cmake -DCMAKE_INSTALL_PREFIX:PATH=./install \
51+
-DCMAKE_CXX_COMPILER:STRING=${CMAKE_CXX_COMPILER:-"mpicxx"} \
52+
-DCMAKE_C_COMPILER:STRING=${CMAKE_C_COMPILER:-"mpicc"} \
53+
-DCMAKE_Fortran_COMPILER:STRING=${CMAKE_Fortran_COMPILER:-"mpifort"} \
54+
-DCMAKE_BUILD_TYPE:STRING=Release \
55+
-DERF_DIM:STRING=3 \
56+
-DERF_ENABLE_MPI:BOOL=ON \
57+
-DERF_ENABLE_CUDA:BOOL=OFF \
58+
-DERF_ENABLE_TESTS:BOOL=OFF \
59+
-DERF_ENABLE_FCOMPARE:BOOL=ON \
60+
-DERF_ENABLE_DOCUMENTATION:BOOL=OFF \
61+
-DCMAKE_EXPORT_COMPILE_COMMANDS:BOOL=ON ..
62+
time make -j fcompare
6363

6464
FCOMPARE_EXE="$(pwd)/Submodules/AMReX/Tools/Plotfile/amrex_fcompare"
6565

@@ -101,28 +101,29 @@ mkdir ${build_dir}
101101
cd ${build_dir}
102102
pwd
103103

104-
cmake -DCMAKE_INSTALL_PREFIX:PATH=./install \
105-
-DCMAKE_CXX_COMPILER:STRING=${CMAKE_CXX_COMPILER:-"mpicxx"} \
106-
-DCMAKE_C_COMPILER:STRING=${CMAKE_C_COMPILER:-"mpicc"} \
107-
-DCMAKE_Fortran_COMPILER:STRING=${CMAKE_Fortran_COMPILER:-"mpifort"} \
108-
-DMPIEXEC_EXECUTABLE="${mpiexec_executable}" \
109-
-DMPIEXEC_PREFLAGS:STRING="${mpiexec_preflags}" \
110-
-DCMAKE_BUILD_TYPE:STRING="${build_type}" \
111-
-DERF_DIM:STRING=3 \
112-
-DERF_ENABLE_MPI:BOOL=ON \
113-
-DERF_ENABLE_CUDA:BOOL="${ERF_ENABLE_CUDA}" \
114-
-DAMReX_CUDA_ARCH:STRING="${CUDA_ARCH:-""}" \
115-
-DERF_ENABLE_HIP:BOOL="${ERF_ENABLE_HIP:-"OFF"}" \
116-
-DAMReX_AMD_ARCH:STRING="${AMD_ARCH:-""}" \
117-
-DERF_ENABLE_TESTS:BOOL=ON \
118-
-DERF_TEST_NRANKS:STRING=${ERF_TEST_NRANKS:-"4"} \
119-
-DERF_ENABLE_FCOMPARE:BOOL=ON \
120-
-DERF_ENABLE_DOCUMENTATION:BOOL=OFF \
121-
-DFCOMPARE_EXE="${FCOMPARE_EXE:-"$(pwd)/Submodules/AMReX/Tools/Plotfile/amrex_fcompare"}" \
122-
-DERF_TEST_GOLD_FILES_DIRECTORY="${ERF_TEST_GOLD_FILES_DIRECTORY:-"$(pwd)/../Tests/ERFGoldFiles"}" \
123-
-DERF_TEST_FCOMPARE_RTOL="${ERF_TEST_FCOMPARE_RTOL:-"5.0e-9"}" \
124-
-DERF_TEST_FCOMPARE_ATOL="${ERF_TEST_FCOMPARE_ATOL:-"2.0e-10"}" \
125-
-DCMAKE_EXPORT_COMPILE_COMMANDS:BOOL=ON \
126-
..
127-
make -j ${OMP_NUM_THREADS:-16}
128-
ctest -VV --output-on-failure
104+
time cmake \
105+
-DCMAKE_INSTALL_PREFIX:PATH=./install \
106+
-DCMAKE_CXX_COMPILER:STRING=${CMAKE_CXX_COMPILER:-"mpicxx"} \
107+
-DCMAKE_C_COMPILER:STRING=${CMAKE_C_COMPILER:-"mpicc"} \
108+
-DCMAKE_Fortran_COMPILER:STRING=${CMAKE_Fortran_COMPILER:-"mpifort"} \
109+
-DMPIEXEC_EXECUTABLE="${mpiexec_executable}" \
110+
-DMPIEXEC_PREFLAGS:STRING="${mpiexec_preflags}" \
111+
-DCMAKE_BUILD_TYPE:STRING="${build_type}" \
112+
-DERF_DIM:STRING=3 \
113+
-DERF_ENABLE_MPI:BOOL=ON \
114+
-DERF_ENABLE_CUDA:BOOL="${ERF_ENABLE_CUDA}" \
115+
-DAMReX_CUDA_ARCH:STRING="${CUDA_ARCH:-""}" \
116+
-DERF_ENABLE_HIP:BOOL="${ERF_ENABLE_HIP:-"OFF"}" \
117+
-DAMReX_AMD_ARCH:STRING="${AMD_ARCH:-""}" \
118+
-DERF_ENABLE_TESTS:BOOL=ON \
119+
-DERF_TEST_NRANKS:STRING=${ERF_TEST_NRANKS:-"4"} \
120+
-DERF_ENABLE_FCOMPARE:BOOL=ON \
121+
-DERF_ENABLE_DOCUMENTATION:BOOL=OFF \
122+
-DFCOMPARE_EXE="${FCOMPARE_EXE:-"$(pwd)/Submodules/AMReX/Tools/Plotfile/amrex_fcompare"}" \
123+
-DERF_TEST_GOLD_FILES_DIRECTORY="${ERF_TEST_GOLD_FILES_DIRECTORY:-"$(pwd)/../Tests/ERFGoldFiles"}" \
124+
-DERF_TEST_FCOMPARE_RTOL="${ERF_TEST_FCOMPARE_RTOL:-"5.0e-9"}" \
125+
-DERF_TEST_FCOMPARE_ATOL="${ERF_TEST_FCOMPARE_ATOL:-"2.0e-10"}" \
126+
-DCMAKE_EXPORT_COMPILE_COMMANDS:BOOL=ON \
127+
..
128+
time make -j ${OMP_NUM_THREADS:-16}
129+
time ctest -VV --output-on-failure

.gitlab/LC/runners/dane.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ release_resources_dane:
4343
stage: release
4444
script:
4545
- export JOBID=$(squeue -h --name=${ALLOC_NAME} --format=%A)
46-
- ([[ -n "${JOBID}" ]] && scancel ${JOBID})
46+
- ([[ -n "${JOBID}" ]] && scancel ${JOBID} || exit 0)
4747
when: always
4848

4949
.job_on_dane:

.gitlab/LC/runners/tioga.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ release_resources_tioga:
4343
stage: release
4444
script:
4545
- export JOBID=$(flux jobs -n --name=${ALLOC_NAME} --format="{id}")
46-
- ([[ -n "${JOBID}" ]] && flux cancel ${JOBID})
46+
- ([[ -n "${JOBID}" ]] && flux cancel ${JOBID} || exit 0)
4747
when: always
4848

4949
.job_on_tioga:

0 commit comments

Comments
 (0)