Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] JOSS Reviewer 2 Omnibus Review Issue #1041

Closed
1 task
adam-m-jcbs opened this issue Apr 7, 2023 · 1 comment
Closed
1 task

[WIP] JOSS Reviewer 2 Omnibus Review Issue #1041

adam-m-jcbs opened this issue Apr 7, 2023 · 1 comment

Comments

@adam-m-jcbs
Copy link

adam-m-jcbs commented Apr 7, 2023

Hello ERF team! I am serving as a reviewer for this JOSS submission:
openjournals/joss-reviews#5202

I'm posting this issue as a single "omnibus" overview of my review. Please do let me know if you would prefer any topics be broken out into dedicated issues.

Resolution of this issue will indicate that this submission satisfied all JOSS criteria for publication and that I recommend it for publication.

Please see my review checklist here for all details and items I've verified as resolved:
openjournals/joss-reviews#5202 (comment)

This issue is currently a WIP! Please bear with me as I work to complete the review, but I wanted to go ahead and get started. I will remove the [WIP] tag and update here when this issue's ready for review.

Minor issue: copyright

The copyright date in the license is 2022. Is this intended? There may be no need or desire to update the copyright date, but I wanted to note it and affirm that 2022 is correct (or that it will be updated).

  • Verify copyright date

to be continued...

@asalmgren
Copy link
Collaborator

The copyright date is 2022 -- that is intended/correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants