Cleanup upw_frac in AdvectionSrc code

[ewquon]

From erf_slow_rhs_pre, horiz_upw_frac and vert_upw_frac are passed:

1. to AdvectionSrcForMom
2. to AdvectionSrcForMomVert_*
3. to AdvectionSrcForMomWrapper_* (where the InterpType_H and InterpType_V structs are instantiated)
4. to AdvectionSrcFor*Mom_*
5. which calls interp_*_h.InterpolateIn* and interp_*_v.InterpolateIn* with upw_frac_h and upw_frac_v, respectively, as arguments.

All the hand offs for step 4 and 5 can be avoided by just instantiating the interp structs in step 3 with the upwind fraction as an argument.

[asalmgren]

This sounds like a good change

[asalmgren]

@ewquon -- is this still something we want to do? Or has it been superseded by other changes to advection?

[ewquon]

@asalmgren I'll take another look. While I'm at it, I'll also want to think about how to make the blending more general for Matt's work.

[asalmgren]

@ewquon -- does your latest PR resolve this issue?

[ewquon]

Yep. Get Outlook for iOS<https://aka.ms/o0ukef>

…

________________________________ From: Ann Almgren ***@***.***> Sent: Tuesday, February 4, 2025 5:42:09 PM To: erf-model/ERF ***@***.***> Cc: Quon, Eliot ***@***.***>; Mention ***@***.***> Subject: Re: [erf-model/ERF] Cleanup `upw_frac` in AdvectionSrc code (Issue #1522) CAUTION: This email originated from outside of NREL. Do not click links or open attachments unless you recognize the sender and know the content is safe. @ewquon<https://github.com/ewquon> -- does your latest PR resolve this issue? — Reply to this email directly, view it on GitHub<#1522 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AELLXM2WW5QKRU3NOZPPZU32OFM6DAVCNFSM6AAAAABVOHD3KSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMZVGQ2TCNJTGA>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[asalmgren]

Thanks!