feat: add no-reversed-media-syntax rule #398
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lumirlumir
requested changes
Jun 3, 2025
There was a problem hiding this comment.
Could you take a look at the false negatives in nested text nodes?
Currently, nested text nodes using emphasis (*), strong (**), strikethrough (~), and inline code blocks using backticks result in false negatives.
(*foo*)[]
(**foo**)[]
(~~foo~~)[]
(`foo`)[]There was a problem hiding this comment.
Hmm these produce 3 text nodes. This should complicate things 😅
nzakas
reviewed
Jun 3, 2025
| // Helpers | ||
| //----------------------------------------------------------------------------- | ||
|
|
||
| const reversedPattern = /(?<!\\)\(((?:\\.|[^()\\])*)\)\[((?:\\.|[^\]\\])*)\]/gu; |
There was a problem hiding this comment.
Can you add a comment showing what this regex is meant to match?
Comment on lines
+65
to
+68
| const { | ||
| lineOffset: endLineOffset, | ||
| columnOffset: endColumnOffset, | ||
| } = findOffsets(text, matchIndex + matchLength); |
There was a problem hiding this comment.
Because the regex only matches single lines, you can just add matchLength to startColumnOffset to get this location instead of calculating it from scratch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
This PR adds a new rule
no-reversed-media-syntaxto enforce correct link and image syntax in Markdown.What changes did you make? (Give an overview)
Added the
no-reversed-media-syntaxrule, along with documentation and tests.Related Issues
Fixes #386
Is there anything you'd like reviewers to focus on?