-
Notifications
You must be signed in to change notification settings - Fork 7.8k
feat(matter): adds dimmable plugin matter endpoint #12105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Hello SuGlider, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds a new Matter endpoint for dimmable plugin units (power outlets with level control), extending the Matter library's device support. The implementation enables ESP32-based devices to function as Matter-compatible dimmable power outlets with both on/off and level (0-255) control capabilities.
Key Changes:
- Adds
MatterDimmablePluginclass with on/off and level control (0-255) - Includes comprehensive example with state persistence using Preferences
- Provides complete API documentation and usage guide
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
libraries/Matter/src/MatterEndpoints/MatterDimmablePlugin.h |
Header defining the MatterDimmablePlugin class with level control API |
libraries/Matter/src/MatterEndpoints/MatterDimmablePlugin.cpp |
Implementation of dimmable plugin endpoint with Matter cluster integration |
libraries/Matter/src/Matter.h |
Adds MatterDimmablePlugin include and friend class declaration |
libraries/Matter/keywords.txt |
Adds syntax highlighting for MatterDimmablePlugin, setLevel, and getLevel |
libraries/Matter/examples/MatterDimmablePlugin/MatterDimmablePlugin.ino |
Example sketch demonstrating plugin control with state persistence and button handling |
libraries/Matter/examples/MatterDimmablePlugin/README.md |
Comprehensive documentation covering setup, usage, and smart home integration |
libraries/Matter/examples/MatterDimmablePlugin/ci.yml |
CI configuration for example testing |
docs/en/matter/matter.rst |
Adds MatterDimmablePlugin to the list of available endpoints |
docs/en/matter/ep_dimmable_plugin.rst |
Complete API reference documentation for the dimmable plugin endpoint |
CMakeLists.txt |
Adds MatterDimmablePlugin.cpp to build system |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Test Results 83 files 83 suites 25m 59s ⏱️ Results for commit dd21e6d. ♻️ This comment has been updated with latest results. |
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| **Use Cases:** | ||
| * Dimmable smart power outlets | ||
| * Variable power control | ||
| * Dimmable relay control |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this supported? Maybe you are referring to SSR (Solid State Relay)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is about the use cases, not the specific components. Yes, it is about SSR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So it's better to mention SSR. Dimmable lights with a relay (coil relays) are not possible, only with an SSR, like a TRIAC.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll remove it. It may be better.
Description of Change
Adds Matter Dimmable Plugin (power outlet) endpoint with related documentation and example.
Test Scenarios
CI
ESP32-S3 with provided example and Alexa Matter environment.
Related links
None