Skip to content

Conversation

@SuGlider
Copy link
Collaborator

@SuGlider SuGlider commented Dec 4, 2025

Description of Change

Adds Matter Dimmable Plugin (power outlet) endpoint with related documentation and example.

Test Scenarios

CI
ESP32-S3 with provided example and Alexa Matter environment.

Related links

None

@SuGlider SuGlider added this to the 3.3.0 milestone Dec 4, 2025
@SuGlider SuGlider self-assigned this Dec 4, 2025
@SuGlider SuGlider added the Area: Matter Issues and Feature Request about Matter Protocol label Dec 4, 2025
@SuGlider SuGlider marked this pull request as draft December 4, 2025 21:17
@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2025

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello SuGlider, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against dd21e6d

Copilot finished reviewing on behalf of SuGlider December 4, 2025 21:20
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new Matter endpoint for dimmable plugin units (power outlets with level control), extending the Matter library's device support. The implementation enables ESP32-based devices to function as Matter-compatible dimmable power outlets with both on/off and level (0-255) control capabilities.

Key Changes:

  • Adds MatterDimmablePlugin class with on/off and level control (0-255)
  • Includes comprehensive example with state persistence using Preferences
  • Provides complete API documentation and usage guide

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
libraries/Matter/src/MatterEndpoints/MatterDimmablePlugin.h Header defining the MatterDimmablePlugin class with level control API
libraries/Matter/src/MatterEndpoints/MatterDimmablePlugin.cpp Implementation of dimmable plugin endpoint with Matter cluster integration
libraries/Matter/src/Matter.h Adds MatterDimmablePlugin include and friend class declaration
libraries/Matter/keywords.txt Adds syntax highlighting for MatterDimmablePlugin, setLevel, and getLevel
libraries/Matter/examples/MatterDimmablePlugin/MatterDimmablePlugin.ino Example sketch demonstrating plugin control with state persistence and button handling
libraries/Matter/examples/MatterDimmablePlugin/README.md Comprehensive documentation covering setup, usage, and smart home integration
libraries/Matter/examples/MatterDimmablePlugin/ci.yml CI configuration for example testing
docs/en/matter/matter.rst Adds MatterDimmablePlugin to the list of available endpoints
docs/en/matter/ep_dimmable_plugin.rst Complete API reference documentation for the dimmable plugin endpoint
CMakeLists.txt Adds MatterDimmablePlugin.cpp to build system

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2025

Test Results

 83 files   83 suites   25m 59s ⏱️
 55 tests  55 ✅ 0 💤 0 ❌
598 runs  598 ✅ 0 💤 0 ❌

Results for commit dd21e6d.

♻️ This comment has been updated with latest results.

@SuGlider SuGlider moved this from Todo to In Review in Arduino ESP32 Core Project Roadmap Dec 4, 2025
@SuGlider SuGlider marked this pull request as ready for review December 4, 2025 21:44
@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2025

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32C5000.000.00000.000.00
ESP32S30⚠️ +2800.00⚠️ +0.02000.000.00
ESP32S20⚠️ +2800.00⚠️ +0.02000.000.00
ESP32C3000.000.00000.000.00
ESP32C6000.000.00000.000.00
ESP32H2000.000.00000.000.00
ESP320⚠️ +2800.00⚠️ +0.02000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32C5ESP32S3ESP32S2ESP32C3ESP32C6ESP32H2ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
libraries/Matter/examples/MatterColorLight00⚠️ +2800⚠️ +2800000000⚠️ +2800
libraries/Matter/examples/MatterCommissionTest00⚠️ +2800⚠️ +2800000000⚠️ +2800
libraries/Matter/examples/MatterComposedLights00⚠️ +2800⚠️ +2800000000⚠️ +2800
libraries/Matter/examples/MatterContactSensor00⚠️ +2800⚠️ +2800000000⚠️ +2800
libraries/Matter/examples/MatterDimmableLight00⚠️ +2800⚠️ +2800000000⚠️ +2800
libraries/Matter/examples/MatterDimmablePlugin--------------
libraries/Matter/examples/MatterEnhancedColorLight00⚠️ +2800⚠️ +2800000000⚠️ +2800
libraries/Matter/examples/MatterEvents00⚠️ +2800⚠️ +2720000000⚠️ +2800
libraries/Matter/examples/MatterFan00⚠️ +2800⚠️ +2800000000⚠️ +2800
libraries/Matter/examples/MatterHumiditySensor00⚠️ +2800⚠️ +2800000000⚠️ +2800
libraries/Matter/examples/MatterLambdaSingleCallbackManyEPs00⚠️ +2800⚠️ +2800000000⚠️ +2800
libraries/Matter/examples/MatterMinimum00⚠️ +2800⚠️ +2800000000⚠️ +2800
libraries/Matter/examples/MatterOccupancySensor00⚠️ +2800⚠️ +2800000000⚠️ +2800
libraries/Matter/examples/MatterOnIdentify00⚠️ +2800⚠️ +2800000000⚠️ +2800
libraries/Matter/examples/MatterOnOffLight00⚠️ +2800⚠️ +2800000000⚠️ +2800
libraries/Matter/examples/MatterOnOffPlugin00⚠️ +2800⚠️ +2800000000⚠️ +2800
libraries/Matter/examples/MatterPressureSensor00⚠️ +2800⚠️ +2800000000⚠️ +2800
libraries/Matter/examples/MatterRainSensor00⚠️ +2800⚠️ +2800000000⚠️ +2800
libraries/Matter/examples/MatterSmartButton00⚠️ +2800⚠️ +2800000000⚠️ +2800
libraries/Matter/examples/MatterTemperatureLight00⚠️ +2800⚠️ +2800000000⚠️ +2800
libraries/Matter/examples/MatterTemperatureSensor00⚠️ +2800⚠️ +2800000000⚠️ +2800
libraries/Matter/examples/MatterThermostat00⚠️ +2800⚠️ +2800000000⚠️ +2800
libraries/Matter/examples/MatterWaterFreezeDetector00⚠️ +2800⚠️ +2800000000⚠️ +2800
libraries/Matter/examples/MatterWaterLeakDetector00⚠️ +2800⚠️ +2800000000⚠️ +2800

@SuGlider SuGlider added the Status: Review needed Issue or PR is awaiting review label Dec 4, 2025
**Use Cases:**
* Dimmable smart power outlets
* Variable power control
* Dimmable relay control
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this supported? Maybe you are referring to SSR (Solid State Relay)?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is about the use cases, not the specific components. Yes, it is about SSR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it's better to mention SSR. Dimmable lights with a relay (coil relays) are not possible, only with an SSR, like a TRIAC.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll remove it. It may be better.

@SuGlider SuGlider added Status: Pending Merge Pull Request is ready to be merged and removed Status: Review needed Issue or PR is awaiting review labels Dec 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: Matter Issues and Feature Request about Matter Protocol Status: Pending Merge Pull Request is ready to be merged

Projects

Status: In Review

Development

Successfully merging this pull request may close these issues.

5 participants