feature(tinyusb): Software VBUS monitoring feature on ESP32P4 (part2/2)

[roma-jam]

Description

VBUS monitoring on ESP32-P4 - Part 2/2

• added GPIO ISR + debounce timer + debounce logic; drive GOTGCTL.BVALID on VBUS appear/disappear.

Related

• Prerequisites in feature(tinyusb): Software VBUS monitoring feature on ESP32P4 (part1/2) #305
• Closes IDF-10720

Testing

• Enabling CI test for vbus_monitor on esp32p4

Verification

Verification is made by launching the vbus_monitor test application test cases.
To verify all scenarios, additional hardware features should be done with a dev board:

1. Connect GPIO4 and GPIO5 together (for controlled vbus test)
2. Add the resistor divider, connected to the +5V of the usb port (the +5V point was taken from the drain of Q3 and Q4)

• ESP32-P4 ECO4
• Does not support ESP32-P4 ECO5 (Support in fix(esp_tinyusb): VBUS monitoring feature on ESP32-P4, USB OTG 2.0 v4.30a #313)

Checklist

Before submitting a Pull Request, please ensure the following:

• 🚨 This PR does not introduce breaking changes.
• All CI checks (GH Actions) pass.
• Documentation is updated as needed.
• Tests are updated or added as necessary.
• Code is well-commented, especially in complex areas.
• Git history is clean — commits are squashed to the minimum necessary.

---

Note

Implements GPIO ISR + debounce-driven VBUS monitoring (with DWC BVALID override/soft-disconnect) on ESP32-P4, updates API to return esp_err, and enables corresponding tests and example setup.

• Device (VBUS monitor):
  • Implement ISR-based GPIO VBUS monitoring with FreeRTOS debounce timer in device/esp_tinyusb/tinyusb_vbus_monitor.c.
  • Add low-level DWC helpers and drive GOTGCTL.BVALID and DCTL.SFTDISCON on VBUS appear/disappear (ESP32-P4).
  • Robust init: single-instance guard, GPIO config/ISR hookup, debounce timer creation, BVALID override enable; start timer if VBUS already high.
  • Deinit now returns esp_err_t; cleans up ISR, GPIO, timer, and disables BVALID override.
  • Header tinyusb_vbus_monitor.h: document new error returns; change tinyusb_vbus_monitor_deinit signature to return esp_err_t.
• Tests (test_vbus_monitor.c):
  • Enable GOTGCTL-based attach/detach test and replace placeholders with real routines.
  • For controlled/real VBUS tests on OTG 2.0, install/uninstall GPIO ISR service.
• Example (MSC test app):
  • On ESP32-P4, install GPIO ISR service before tinyusb_driver_install in msc_device.c.

^{Written by Cursor Bugbot for commit 6b9d6ea. This will update automatically on new commits. Configure here.}

[Copilot]

Pull Request Overview

This PR implements software VBUS monitoring functionality for ESP32P4, the second part of a two-part implementation. It adds GPIO-based interrupt handling with debounce logic to detect VBUS presence and automatically control USB device connection/disconnection by overriding the GOTGCTL.BVALID signal.

• Implements GPIO ISR with debounce timer for VBUS state detection
• Adds low-level USB DWC register manipulation functions for BVALID override control
• Enables previously disabled test cases for VBUS monitoring functionality

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
tinyusb_vbus_monitor.c	Core implementation of VBUS monitoring with GPIO ISR, debounce logic, and USB register control
test_vbus_monitor.c	Enables test cases by replacing placeholder return values with actual test function calls
tinyusb_vbus_monitor.h	Updates function signatures and documentation for new return types and error handling

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[cursor]

This is the final PR Bugbot will review for you during this billing cycle

Your free Bugbot reviews will reset on November 20

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

[Copilot]

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[roma-jam]

Hi
@tore-espressif
@peter-marcisovsky
@igi540

This PR is ready. PTAL!

[tore-espressif]

Did you get expected results in this testcase?

IIRC, the USB-DWC does not only check state of BVALID signal but also state of D+ and D-. Eg. if you deassert bValid, but D+ and D- stay connected, the detachment might not be detected