review comments

alirana01 · alirana01 · commit b7fd36dfadf6 · 2023-09-13T13:48:04.000+02:00
diff --git a/bundles/com.espressif.idf.ui/src/com/espressif/idf/ui/gcov/GcovFileView.java b/bundles/com.espressif.idf.ui/src/com/espressif/idf/ui/gcov/GcovFileView.java
@@ -93,9 +93,11 @@ public void handleEvent(Event event)
 			{
 				Point pt = new Point(event.x, event.y);
 				TableItem item = table.getItem(pt);
+				if (item == null)
+					return;
 				IFile file = (IFile) item.getData();
 
-				if (item != null && file != null)
+				if (file != null)
 				{
 					try
 					{
@@ -104,7 +106,7 @@ public void handleEvent(Event event)
 					}
 					catch (PartInitException e)
 					{
-						e.printStackTrace();
+						Logger.log(e);
 					}
 				}
 			}

Original file line number	Diff line number	Diff line change
`@@ -93,9 +93,11 @@ public void handleEvent(Event event)`
`93`	`93`	`{`
`94`	`94`	`Point pt = new Point(event.x, event.y);`
`95`	`95`	`TableItem item = table.getItem(pt);`
	`96`	`+ if (item == null)`
	`97`	`+ return;`
`96`	`98`	`IFile file = (IFile) item.getData();`
`97`	`99`
`98`		`- if (item != null && file != null)`
	`100`	`+ if (file != null)`
`99`	`101`	`{`
`100`	`102`	`try`
`101`	`103`	`{`
`@@ -104,7 +106,7 @@ public void handleEvent(Event event)`
`104`	`106`	`}`
`105`	`107`	`catch (PartInitException e)`
`106`	`108`	`{`
`107`		`- e.printStackTrace();`
	`109`	`+ Logger.log(e);`
`108`	`110`	`}`
`109`	`111`	`}`
`110`	`112`	`}`