nRF52840: Ensure scannable is disabled (and warn) when advertising on coded phy

as per #2465 (comment)

Author: gfwilliams

ChangeLog

@@ -41,6 +41,7 @@
             Add pretokenisation of 8/16 bit ints (fix #2563)
             nRF5x: Fix BLE connection timeout (was 40ms, not 4s) for more reliable outgoing connections
             Bangle.js2/Jolt.js: Increase GAP_EVENT_LENGTH to allow coded phy connections (1.2k more RAM used)
+            nRF52840: Ensure scannable is disabled (and warn) when advertising on coded phy
 
      2v25 : ESP32C3: Get analogRead working correctly
             Graphics: Adjust image alignment when rotating images to avoid cropping (fix #2535)

targets/nrf5x/bluetooth.c

@@ -2787,9 +2787,14 @@ uint32_t jsble_advertising_start() {
           ? (non_scannable ? BLE_GAP_ADV_TYPE_NONCONNECTABLE_NONSCANNABLE_UNDIRECTED : BLE_GAP_ADV_TYPE_NONCONNECTABLE_SCANNABLE_UNDIRECTED)
           : (non_scannable ? BLE_GAP_ADV_TYPE_CONNECTABLE_NONSCANNABLE_DIRECTED : BLE_GAP_ADV_TYPE_CONNECTABLE_SCANNABLE_UNDIRECTED);
   } else { // coded/2mbps - force use of extended advertising
+    if (!non_scannable) {
+      jsWarn("Extended/coded advertisements can only be used with scannable:false. Disabling scan response.\n");
+      bleStatus |= BLE_IS_NOT_SCANNABLE;
+      non_scannable = true;
+    }
     adv_params.properties.type = non_connectable
         ? (non_scannable ? BLE_GAP_ADV_TYPE_EXTENDED_NONCONNECTABLE_NONSCANNABLE_UNDIRECTED : BLE_GAP_ADV_TYPE_EXTENDED_NONCONNECTABLE_SCANNABLE_UNDIRECTED)
-        : (non_scannable ? BLE_GAP_ADV_TYPE_EXTENDED_CONNECTABLE_NONSCANNABLE_UNDIRECTED : BLE_GAP_ADV_TYPE_CONNECTABLE_SCANNABLE_UNDIRECTED);
+        : BLE_GAP_ADV_TYPE_EXTENDED_CONNECTABLE_NONSCANNABLE_UNDIRECTED;
   }
 #else
   adv_params.type        = non_connectable